[JitLayer]Split layer_utils.cc and polish interface BaseFunction #43754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Jun 22, 2022
| return schema_.GetInputArgNames(); | ||
| } | ||
|
|
||
| const std::vector<std::string> FunctionInfo::GetOutputArgNames() const { |
There was a problem hiding this comment.
后续我们可以把Get前缀去掉，因为API名字太长了
| #include "paddle/fluid/framework/program_desc.h" | ||
| #include "paddle/phi/core/enforce.h" | ||
|
|
||
| #include "paddle/fluid/jit/layer_utils.h" |
There was a problem hiding this comment.
这里应该不需要依赖layer_utils.h 头文件？
paddle/fluid/jit/layer.cc
Outdated
| function_dict[func_names[i]] = std::make_shared<ExectorFunction>( | ||
| program_descs[i], param_names_for_each_program[i], params_dict, place); | ||
| function_dict_[infos[i]->GetFunctionName()] = | ||
| std::make_shared<ExectorFunction>(infos[i], params_dict_, place); |
There was a problem hiding this comment.
这里我们是默认创建了ExecutorFuntion，后续统一到CompilationUnit后，我们可以Lazy模式创建这些执行引擎
sneaxiy
pushed a commit
to sneaxiy/Paddle
that referenced
this pull request
Jun 27, 2022
…dlePaddle#43754) * Split layer_utils.cc and polish interface BaseFunction * Polish include * Fix cmake for funciton_schema * Using unordered_map replace map and rename VariableNameMap * Polish Layer Constructor and remove useless include * Refine compilation_unit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[JitLayer]Split layer_utils.cc and polish interface BaseFunction