Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProcessGroup] Support new apis in ProcessGroupNCCL #43918

Merged
merged 13 commits into from
Jul 11, 2022
Merged

[ProcessGroup] Support new apis in ProcessGroupNCCL #43918

merged 13 commits into from
Jul 11, 2022

Conversation

haohongxiang
Copy link
Contributor

@haohongxiang haohongxiang commented Jun 28, 2022 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

[ProcessGroup] Support new apis in ProcessGroupNCCL
[docs_cn] PR-4969 / Preview Link

@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

ForFishes
ForFishes approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeff41404
jeff41404 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name and parameter of API design meet the Paddle specification requirements, so approve.

XiaoguangHu01
XiaoguangHu01 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XieYunshen
XieYunshen approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for
set_tests_properties(test_collective_alltoall_single PROPERTIES TIMEOUT 60) set_tests_properties(test_collective_batch_isend_irecv PROPERTIES TIMEOUT 100) set_tests_properties(test_collective_reduce_scatter PROPERTIES TIMEOUT 100)

@gongweibao gongweibao mentioned this pull request Jul 11, 2022
Merged
@ForFishes ForFishes merged commit 37216a8 into PaddlePaddle:develop Jul 11, 2022
@haohongxiang haohongxiang changed the title [Dygraph] Support new apis in ProcessGroupNCCL [ProcessGroup] Support new apis in ProcessGroupNCCL Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@dingjiaweiww dingjiaweiww dingjiaweiww approved these changes

@ForFishes ForFishes ForFishes approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haohongxiang @jeff41404 @ForFishes @dingjiaweiww @XieYunshen @XiaoguangHu01