Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pool avg to quantization and concat scales correction #44186

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Add pool avg to quantization and concat scales correction #44186

merged 1 commit into from
Jul 12, 2022

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Jul 8, 2022

PR types

Performance optimization

PR changes

Others

Describe

This PR:

  • adds average pool2d to QAT OneDNN quantization process, because 3 years ago there was some problems with scale calculation for this, but it is not valid now.
  • corrects concat scale propagation, so when after concat we know output scale we can rewrite it to concat's inputs.

Both changes will improve performance about 5% in INT8 Picodet model.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 8, 2022
@paddle-bot
Copy link

paddle-bot bot commented Jul 8, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wozna wozna added Intel int8 and removed contributor External developers status: proposed labels Jul 8, 2022
lidanqing-intel
lidanqing-intel approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-intel
Copy link
Contributor

@yaomichael This PR speedup picodet INT8 by 5% as Joanna commented.

sfraczek
sfraczek approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@sfraczek sfraczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-intel lidanqing-intel merged commit c797e64 into PaddlePaddle:develop Jul 12, 2022
@paddle-bot
Copy link

paddle-bot bot commented Jul 12, 2022

你的PR已合入Paddle库，请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

@wozna wozna deleted the concat_pool branch February 24, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfraczek sfraczek sfraczek approved these changes

@lidanqing-intel lidanqing-intel lidanqing-intel approved these changes

Assignees
No one assigned
Labels
int8 Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wozna @lidanqing-intel @sfraczek