Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stridecpy instead of eigen in PadGradKernel. #4431

Closed
wants to merge 1 commit into from
Closed

Use stridecpy instead of eigen in PadGradKernel. #4431

wants to merge 1 commit into from

Conversation

wanghaoshuang
Copy link
Contributor

fix #4430

dzhwinter
dzhwinter approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dzhwinter
Copy link
Contributor

Seems we need to wrapper more math function over eigen, which may save a lot of lines of code.

@Yancey1989 Yancey1989 mentioned this pull request Feb 27, 2018
Closed
@wanghaoshuang wanghaoshuang deleted the fix_pad branch May 20, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use stridecpy instead of eigen in PadGradKernel.
2 participants
@wanghaoshuang @dzhwinter