move renorm op #44676
Merged
move renorm op #44676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
reviewed
Aug 2, 2022
paddle/phi/kernels/funcs/renorm.h
Outdated
Comment on lines
32
to
34
| // #if defined(__NVCC__) || defined(__HIPCC__) | ||
| // #include "paddle/fluid/platform/device/gpu/gpu_primitives.h" | ||
| // #endif |
paddle/phi/kernels/funcs/renorm.h
Outdated
Comment on lines
53
to
54
| // auto& dev_ctx = ctx.template device_context<DeviceContext>(); | ||
| // std::vector<int64_t> dim_index(dim_size, 0); |
paddle/phi/kernels/funcs/renorm.h
Outdated
Comment on lines
58
to
59
| // auto* out_data = | ||
| // out->mutable_data<T>(context.GetPlace(), size_t(numel * sizeof(T))); |
paddle/phi/kernels/funcs/renorm.h
Outdated
| for (int i = 0; i < dim; i++) pre_mul *= input_dims[i]; | ||
| pow_value.Resize(phi::make_ddim({pre_mul, dimension_each, dim_divisor})); | ||
| dim_value.Resize(phi::make_ddim({dimension_each})); | ||
| // pow_value.mutable_data<T>(context.GetPlace()); |
paddle/phi/kernels/funcs/renorm.h
Outdated
Comment on lines
302
to
303
| // out->Resize(phi::make_ddim(phi::vectorize(input_dims))); | ||
| // T* out_data = out->mutable_data<T>(context.GetPlace()); |
paddle/phi/kernels/funcs/renorm.h
Outdated
Comment on lines
312
to
319
| // std::vector<const framework::Tensor*> ins = {x}; | ||
| // std::vector<framework::Tensor*> outs = {&pow_value}; | ||
| // auto func = UnsignedPowFunctor<MT, T>(p); | ||
| // const auto& cuda_ctx = | ||
| // context.template device_context<platform::CUDADeviceContext>(); | ||
|
|
||
| // paddle::operators::LaunchSameDimsElementwiseCudaKernel<T>( | ||
| // cuda_ctx, ins, &outs, func); |
paddle/phi/kernels/funcs/renorm.h
Outdated
|
|
||
| #pragma once | ||
|
|
||
| #include "paddle/fluid/memory/buffer.h" |
Comment on lines
+1755
to
+1758
| py_test_modules(test_renorm_op_without_eager MODULES test_renorm_op ENVS | ||
| FLAGS_enable_eager_mode=0) | ||
|
|
||
| set_tests_properties(test_renorm_op_without_eager PROPERTIES TIMEOUT 120) |
paddle/phi/kernels/funcs/renorm.h
Outdated
| @@ -0,0 +1,390 @@ | |||
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
这个文件我看只有renorm用到了，可以放到impl下，funcs下一般是放置通用的函数
YuanRisheng
approved these changes
Aug 2, 2022
XieYunshen
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
move renorm op