-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PaddlePaddle Hackathon 3 No.23】为 Paddle 新增 paddle.incubate.sparse.is_same_shape 稀疏 API #45086
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
@zhouwei25 ci 里无关的测试挂了一堆,麻烦帮看下,或者rerun pls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注明下:这里由于paddle的Tensor.size表示的是元素个数,而不是形状,和其他框架有差异,所以API名:is_same_shape更合适些
已更新 @zhouwei25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gsq7474741 需要rerun下失败的CI |
d16e02d
@zhouwei25 已修改code style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
请补充一下中文API文档哈 |
目前sparse文档补充到哪个路径下呀 |
我在学习这个任务,我把这个PR完全抄过去建立了新PR,同样出现 “conflicts”的问题,解决“conflicts”后出现了 9个CI失败,但似乎都与paddle.incubate.sparse.is_same_shape 稀疏 API无关 |
没事 这个不是什么问题 |
飞桨黑客松2期时说是这个,不知道现在变了没有 你好,麻烦新增目录 https://github.com/PaddlePaddle/docs/tree/develop/docs/api/paddle/incubate/sparse |
飞桨黑客松2期时说是这个,不知道现在变了没有 PaddlePaddle/docs#4705 |
@gsq7474741 Sparse API docs:PaddlePaddle/docs#5208 |
PaddlePaddle/docs#4705 |
@gsq7474741 麻烦修复一下CI问题,我觉得可以先合入了 |
已更新 |
英文API文档部分参考这个做一下修改吧,别的部分ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…_same_shape 稀疏 API (PaddlePaddle#45086) * add paddle.incubate.sparse.is_same_shape * add paddle.incubate.sparse.is_same_shape * add paddle.incubate.sparse.is_same_shape * add paddle.incubate.sparse.is_same_shape * fix doc
PR types
New features
PR changes
APIs
Describe
为 Paddle 新增 paddle.incubate.sparse.is_same_shape 稀疏 API
related link