Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiler] add views in summary API #45225

Merged
merged 2 commits into from
Aug 19, 2022
Merged

[Profiler] add views in summary API #45225

merged 2 commits into from
Aug 19, 2022

Conversation

kuizhiqing
Copy link
Member

@kuizhiqing kuizhiqing commented Aug 17, 2022 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

  • add enum type SummaryView
  • add views in API summary to define which SummaryView to show in summary API

Usage

from paddle.profiler import SummaryView
...
p.summary(sorted_by=profiler.SortedKeys.GPUTotal, views=[SummaryView.MemoryView, SummaryView.KernelView])

Only views in the list will be shown.

NOTE: the default value of views is None, which make this change compatible.

@paddle-bot
Copy link

paddle-bot bot commented Aug 17, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

rainyfly
rainyfly previously approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@rainyfly rainyfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeff41404
jeff41404 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuizhiqing kuizhiqing mentioned this pull request Aug 19, 2022
Merged
Ligoml
Ligoml approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

sneaxiy
sneaxiy approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 194d16c into PaddlePaddle:develop Aug 19, 2022
@kuizhiqing kuizhiqing mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

@sneaxiy sneaxiy sneaxiy approved these changes

@Ligoml Ligoml Ligoml approved these changes

@rainyfly rainyfly rainyfly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kuizhiqing @jeff41404 @rainyfly @sneaxiy @Ligoml