Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PaddlePaddle Hackathon 3 No.14】为 Paddle 新增 remainder_ API #45266

Merged
merged 9 commits into from
Aug 31, 2022
Merged

【PaddlePaddle Hackathon 3 No.14】为 Paddle 新增 remainder_ API #45266

merged 9 commits into from
Aug 31, 2022

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Aug 19, 2022 •
edited
Loading

@paddle-bot
Copy link

paddle-bot bot commented Aug 19, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 19, 2022
@paddle-bot
Copy link

paddle-bot bot commented Aug 19, 2022 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@zrr1999 zrr1999 mentioned this pull request Aug 19, 2022
Merged
@zrr1999 zrr1999 marked this pull request as ready for review August 19, 2022 11:34
@zrr1999 zrr1999 mentioned this pull request Aug 19, 2022
Closed
@zrr1999
Copy link
Member Author

zrr1999 commented Aug 23, 2022

@thunder95 麻烦任务 leader 确认一下

@thunder95
Copy link
Contributor

@thunder95 麻烦任务 leader 确认一下

@zrr1999 大佬　为啥需要我确认？我怎么确认？

@Ligoml
Copy link
Contributor

Ligoml commented Aug 23, 2022

@thunder95 麻烦任务 leader 确认一下

@zrr1999 大佬　为啥需要我确认？我怎么确认？

因为提案是你交的呀~所以后面其他开发者完成了这个任务也会请求你来 review 一下呢，是写在活动详情里的：

image

@thunder95
Copy link
Contributor

@thunder95 麻烦任务 leader 确认一下

@zrr1999 大佬　为啥需要我确认？我怎么确认？

因为提案是你交的呀~所以后面其他开发者完成了这个任务也会请求你来 review 一下呢，是写在活动详情里的：

image

@Ligoml 那应该在怎么地方确认，　在这里回复一下就好了么？

thunder95
thunder95 previously approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@thunder95 thunder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zrr1999
Copy link
Member Author

zrr1999 commented Aug 23, 2022

LGTM

@thunder95 麻烦任务 leader 确认一下

@zrr1999 大佬　为啥需要我确认？我怎么确认？

好的谢啦，我也是在那个文档里看到要艾特一下 leader确认的

@zrr1999 zrr1999 requested a review from betterpig August 23, 2022 08:27
betterpig
betterpig previously approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@betterpig betterpig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/paddle/fluid/tests/unittests/test_inplace.py Outdated Show resolved Hide resolved
@zrr1999 zrr1999 requested review from thunder95 and betterpig and removed request for thunder95 August 25, 2022 09:13
@betterpig
Copy link
Contributor

已approve

Ligoml
Ligoml previously approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs
对应的中文文档需要再补充一些内容

@zrr1999 zrr1999 dismissed stale reviews from Ligoml, betterpig, and thunder95 via d5b45e4 August 26, 2022 08:03
@zrr1999
Copy link
Member Author

zrr1999 commented Aug 27, 2022

LGTM for docs 对应的中文文档需要再补充一些内容

好的，已经修改完毕

SigureMo
SigureMo previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs，中文文档需要稍微修改下～

python/paddle/fluid/tests/unittests/test_elementwise_mod_op.py Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_inplace.py Outdated Show resolved Hide resolved
jeff41404
jeff41404 previously approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zrr1999 zrr1999 requested review from SigureMo and removed request for betterpig August 30, 2022 07:39
Ligoml
Ligoml previously approved these changes Aug 30, 2022
View reviewed changes
@zrr1999 zrr1999 dismissed stale reviews from Ligoml and jeff41404 via a5b8a5a August 30, 2022 07:49
SigureMo
SigureMo approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs and unittest～

@luotao1 luotao1 merged commit fe2bfe1 into PaddlePaddle:develop Aug 31, 2022
@SigureMo SigureMo mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@SigureMo SigureMo SigureMo approved these changes

@Ligoml Ligoml Ligoml approved these changes

@jeff41404 jeff41404 jeff41404 left review comments

@thunder95 thunder95 thunder95 left review comments

@betterpig betterpig betterpig left review comments

Assignees

@luotao1 luotao1

@Ligoml Ligoml

@betterpig betterpig

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zrr1999 @CLAassistant @thunder95 @Ligoml @betterpig @luotao1 @jeff41404 @SigureMo