Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpAttr]Adapt tensor axis for argmin/max #45453

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Aug 26, 2022

PR types

Others

PR changes

Others

Describe

[OpAttr]Adapt tensor axis for argmin/max

@paddle-bot
Copy link

paddle-bot bot commented Aug 26, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Aurelius84
Aurelius84 previously approved these changes Aug 29, 2022
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 6fc1598 into PaddlePaddle:develop Aug 30, 2022
@0x45f 0x45f deleted the attr-argmin/max branch August 30, 2022 07:53
if (keepdims) {
vec = std::vector<int64_t>(x.dims().size(), -1);
} else {
vec = std::vector<int64_t>(x.dims().size() - 1, -1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看不懂这里的shape的逻辑,是静态图?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants