Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paddle-TRT] Full support for ops with persistable input #45545

Merged
merged 9 commits into from
Sep 20, 2022
Merged

[Paddle-TRT] Full support for ops with persistable input #45545

merged 9 commits into from
Sep 20, 2022

Conversation

zhoutianzi666
Copy link
Contributor

@zhoutianzi666 zhoutianzi666 commented Aug 30, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Full support for weight input in Paddle-TRT

  • 对于Op的持久类型的输入，以前的处理方式是在op_conver.h中集中处理将它们转化为Itensor，且只处理了Op的X，Y，INput名字的权重输入，对于其它情况（Op的输入名字远不止前述3种）缺乏支持。
  • 此Pr将scope参数传递给engine的scope_，并且丰富了接口GetITensor的作用：若参数Name已经拥有对应的Itensor则直接将其返回，否则将在scope_中找到这个持久型数据，将其转化为Itensor。
  • 好处：不用更改在convert中被广泛使用的GetITensor函数的接口。

@paddle-bot
Copy link

paddle-bot bot commented Aug 30, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 30, 2022
@zhoutianzi666 zhoutianzi666 changed the title [Paddle-TRT] Fully support weight input [Paddle-TRT] Full support for persistent input for ops Sep 19, 2022
@zhoutianzi666 zhoutianzi666 changed the title [Paddle-TRT] Full support for persistent input for ops [Paddle-TRT] Full support for ops with persistent input Sep 19, 2022
@zhoutianzi666 zhoutianzi666 changed the title [Paddle-TRT] Full support for ops with persistent input [Paddle-TRT] Full support for ops with persist input Sep 19, 2022
@zhoutianzi666 zhoutianzi666 changed the title [Paddle-TRT] Full support for ops with persist input [Paddle-TRT] Full support for ops with persistable input Sep 19, 2022
@zhoutianzi666 zhoutianzi666 reopened this Sep 20, 2022
@paddle-bot
Copy link

paddle-bot bot commented Sep 20, 2022

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

weishengying
weishengying approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@weishengying weishengying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhangjun
zhangjun approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@zhangjun zhangjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingqing01 qingqing01 merged commit 668ffd5 into PaddlePaddle:develop Sep 20, 2022
zhoutianzi666 added a commit to zhoutianzi666/Paddle that referenced this pull request Sep 20, 2022
@zhoutianzi666
[Paddle-TRT] Full support for ops with persistable input (PaddlePaddl…
335c79e 
…e#45545)

* Move ITensor construction for Weight (persistable variable) from OpConvert to TensorRTEngine.
qingqing01 pushed a commit that referenced this pull request Sep 20, 2022
@zhoutianzi666
[Paddle-TRT] Full support for ops with persistable input (#45545) (#4…
adb2f5e 
…6280)

* Move ITensor construction for Weight (persistable variable) from OpConvert to TensorRTEngine.
@zhoutianzi666 zhoutianzi666 mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangjun zhangjun zhangjun approved these changes

@qingqing01 qingqing01 qingqing01 approved these changes

@jiweibo jiweibo jiweibo approved these changes

@weishengying weishengying weishengying approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhoutianzi666 @zhangjun @qingqing01 @jiweibo @weishengying