-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support broadcast elementwise operators with int64 index type #45741
Merged
sneaxiy
merged 16 commits into
PaddlePaddle:develop
from
sneaxiy:support_int64_non_broadcast
Sep 16, 2022
Merged
Support broadcast elementwise operators with int64 index type #45741
sneaxiy
merged 16 commits into
PaddlePaddle:develop
from
sneaxiy:support_int64_non_broadcast
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
sneaxiy
force-pushed
the
support_int64_non_broadcast
branch
from
September 7, 2022 01:39
a2488d3
to
f74bbf2
Compare
sneaxiy
force-pushed
the
support_int64_non_broadcast
branch
from
September 7, 2022 03:36
f74bbf2
to
b7b0100
Compare
sneaxiy
force-pushed
the
support_int64_non_broadcast
branch
from
September 7, 2022 05:32
5336814
to
b44bec9
Compare
sneaxiy
force-pushed
the
support_int64_non_broadcast
branch
from
September 7, 2022 06:19
b44bec9
to
ed3cc0a
Compare
sneaxiy
force-pushed
the
support_int64_non_broadcast
branch
from
September 8, 2022 06:17
f0ce66c
to
c081861
Compare
sneaxiy
changed the title
Support non-broadcast elementwise operators with int64 index type
Support broadcast elementwise operators with int64 index type
Sep 8, 2022
sneaxiy
force-pushed
the
support_int64_non_broadcast
branch
from
September 13, 2022 07:56
9406423
to
0358f91
Compare
sneaxiy
requested review from
Shixiaowei02,
Xreki,
JiabinYang,
phlrain and
qingqing01
September 14, 2022 04:56
… support_int64_non_broadcast
FeixLiu
approved these changes
Sep 16, 2022
qingqing01
approved these changes
Sep 16, 2022
Shixiaowei02
approved these changes
Sep 16, 2022
tianshuo78520a
approved these changes
Sep 16, 2022
JiabinYang
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Support broadcast elementwise operators with int64 index type when the numel of the tensor is larger than
INT32_MAX
.NOTE: This PR makes the PaddlePaddle wheel and libpaddle_inference.so increase about 70M. The reason is that the
BroadcastKernel
is a commonly used C++ template function, and it is instantiated many times (for different data types, different operators, etc). It is inevitable so far.