Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing SGD inputs and outputs to conform to Operator naming convention #4586

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Changing SGD inputs and outputs to conform to Operator naming convention #4586

merged 1 commit into from
Oct 4, 2017

Conversation

abhinavarora
Copy link
Contributor

Fixes #4585

@abhinavarora abhinavarora self-assigned this Oct 4, 2017
dzhwinter
dzhwinter approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@abhinavarora abhinavarora merged commit eed2c1e into PaddlePaddle:develop Oct 4, 2017
@abhinavarora abhinavarora deleted the issue_4585 branch October 4, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

@sidgoyal78 sidgoyal78 Awaiting requested review from sidgoyal78

Assignees

@abhinavarora abhinavarora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavarora @dzhwinter