Unify core_avx and core_noavx to paddle_core #45895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
chenwhql
changed the title
chenwhql
changed the title
dingjiaweiww
approved these changes
Sep 15, 2022
jeff41404
approved these changes
Sep 15, 2022
pangyoki
reviewed
Sep 15, 2022
| @@ -1635,6 +1638,7 @@ All parameter, weight, gradient are variables in Paddle. | |||
| m.def("init_devices", []() { framework::InitDevices(); }); | |||
| m.def("init_default_kernel_signatures", | |||
| []() { framework::InitDefaultKernelSignatureMap(); }); | |||
| m.def("is_compiled_with_avx", IsCompiledWithCUDA); | |||
There was a problem hiding this comment.
IsCompiledWithCUDA -> IsCompiledWithAVX ？
|
|
||
| if avx_supported(): | ||
| if platform.system().lower() != 'darwin' or (platform.system().lower() | ||
| == 'darwin' and avx_supported()): |
There was a problem hiding this comment.
是不是没有考虑这种情况：用户机器是支持avx的，但是安装了noavx包（只编译noavx的安装包，没有把avx和noavx合并）。
这时候这个包里没有paddle_core？
| libs = [':core_avx.so'] | ||
| if not core.has_avx_core and core.has_noavx_core: | ||
| libs = [':core_noavx.so'] | ||
| libs = [':paddle_core.so'] |
There was a problem hiding this comment.
macos上只编noavx会不会有问题？
原来这段判断是否需要对macos特殊处理？
if not core.has_avx_core and core.has_noavx_core:
libs = [':core_noavx.so']
| libs = [':core_avx.so'] | ||
| if not core.has_avx_core and core.has_noavx_core: | ||
| libs = [':core_noavx.so'] | ||
| libs = [':paddle_core.so'] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
Unify core_avx and core_noavx to paddle_core
之前paddle为了使一个whl包同时支持avx和noavx，采用了一种比较trick的方式，编译两遍paddle，分别编译avx和noavx，最后打包到一起，#17889
这种方式虽然解决了问题，但也引入了新的问题：
本PR清理了一些历史代码，将动态库名称统一改为
paddle_core同时需要在PaddleCustomDevice中对这两个命名的使用增加一个if分支：https://github.com/PaddlePaddle/PaddleCustomDevice/search?q=core_avx
PaddlePaddle/PaddleCustomDevice#105
TODO：参考linux shared library的命名公约，下个PR更名为libpaddle：https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html