Simplify the code of conv. #45966
Merged
Simplify the code of conv. #45966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Xreki
force-pushed
the
autotune/conv_opt
branch
from
8dd1870
to
2bf4558
Compare
Xreki
force-pushed
the
autotune/conv_opt
branch
from
2bf4558
to
e6ce387
Compare
JamesLim-sy
reviewed
Sep 14, 2022
| CudnnAlgorithmsCacheMap& GetConv(const AlgorithmType& algo_type) { | ||
| return cudnn_auto_tune_map_[static_cast<int64_t>(algo_type)]; | ||
| } | ||
|
|
||
| CudnnAlgorithmsCacheMap& GetConvForward() { |
There was a problem hiding this comment.
这些Get 成员方法，感觉不再需要了，应该可以删除：
CudnnAlgorithmsCacheMap& GetConvForward()
CudnnAlgorithmsCacheMap& GetConvBackwardData()
CudnnAlgorithmsCacheMap& GetConvBackwardFilter()
或者再提交1个PR删除这些代码
There was a problem hiding this comment.
这几个函数，我是考虑后面有没有可能需要再用到，所以暂时没删。
b3602sss
pushed a commit
to b3602sss/Paddle
that referenced
this pull request
Sep 14, 2022
Xreki
added a commit
to Xreki/Paddle
that referenced
this pull request
Oct 20, 2022
lanxianghit
pushed a commit
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
OP Benchmark CI运行情况：conv2d_5 forward fail。运行详情如下，所选择的kernel一样，但是执行时间稍有差异，应该是由于波动引起。