[PHI] Revert pool and pool_grad oneDNN kernel conversion #45989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
chenwhql
approved these changes
Sep 13, 2022
|
@chenwhql Please merge |
paddle-bot-old
bot
added
contributor
piotrekobi
requested review from
jczaja and
chenwhql
and removed request for
jczaja and
chenwhql
|
你的PR已合入Paddle库，请关注后续测试结果。 |
Silv3S
pushed a commit
to Silv3S/Paddle
that referenced
this pull request
Oct 10, 2022
phlrain
pushed a commit
that referenced
this pull request
Oct 11, 2022
phlrain
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Revert pool+grad oneDNN kernel conversion (#45989) * [PHI] transpose2_grad op migration (#46139) * op migrated, Copy(OneDNNContext, ...) added * mutable_data & op registration in fluid removed * refactoring * OneDNNGetDataType to uppercase * missing cpu check added, handler moved to .h file * name changed to transpose_grad * Copy changed back to TensorCopy * Resizing corrected, Copy(OneDNNContext) removed Co-authored-by: Piotr Paturej <48731682+piotrekobi@users.noreply.github.com> Co-authored-by: Paulina Gacek <paulina.gacek@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Reverts the conversion of the pool2d fluid oneDNN kernel to PHI based on feedback from #45954. Converting this op without using the is_test argument caused up to a 3x performance decrease in some models, so it should be reverted as soon as possible.