Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python link order error on cc_test test_egr_performance_benchmark_eager_cpu #46259

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Fix python link order error on cc_test test_egr_performance_benchmark_eager_cpu #46259

merged 1 commit into from
Sep 20, 2022

Conversation

engineer1109
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

Due to #46097
test_egr_performance_benchmark_eager_cpu 这个单元测试的库链接顺序有问题
它的依赖performance_benchmark_utils使用cc_library函数构建，
其中python的link顺序太靠前，导致libfinal_dygraph_function.a找不到python的ABI接口
这里改成在link的末端加入python的依赖。

@paddle-bot
Copy link

paddle-bot bot commented Sep 20, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Sep 20, 2022
@engineer1109 engineer1109 mentioned this pull request Sep 20, 2022
Closed
pmajchrzak
pmajchrzak approved these changes Sep 20, 2022
View reviewed changes
Copy link

@pmajchrzak pmajchrzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 self-assigned this Sep 20, 2022
@luotao1 luotao1 merged commit 048c4e3 into PaddlePaddle:develop Sep 20, 2022
chenwhql pushed a commit to chenwhql/Paddle that referenced this pull request Nov 9, 2022
@engineer1109 @chenwhql
Fix Python Link Order Error (PaddlePaddle#46259)
eb4981b
XiaoguangHu01 pushed a commit that referenced this pull request Nov 10, 2022
@chenwhql @engineer1109 @wanghuancoder
[Cherry-pick] Fix python link error (#47811)
ff642c6 
* Fix Python Link Order Error (#46259)

* fix cc_library link python lib (#47605)

* fix cc_library link python lib

Co-authored-by: engineer <1292846099@qq.com>
Co-authored-by: wanghuancoder <wanghuan29@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmajchrzak pmajchrzak pmajchrzak approved these changes

@luotao1 luotao1 luotao1 approved these changes

Assignees

@luotao1 luotao1

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engineer1109 @luotao1 @pmajchrzak