Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle] format some dy2static unittests #46463

Merged
merged 10 commits into from
Sep 28, 2022

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Sep 23, 2022

PR types

Others

PR changes

Others

Describe

格式化两个被禁用格式化的动转静单测 test_error 和 test_origin_info,移除 future import

更新单测行号

@paddle-bot
Copy link

paddle-bot bot commented Sep 23, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Sep 23, 2022
@SigureMo SigureMo changed the title [CodeStyle] reformat test_error [WIP][CodeStyle] reformat test_error Sep 23, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle] reformat test_error [WIP][CodeStyle] format some dy2static unittests Sep 23, 2022
@@ -153,7 +154,7 @@ def set_static_lineno(self):
def set_dygraph_info(self):
self.line_num = 5
self.line_index_list = [0, 1, 2, 3, 4]
self.dy_rel_lineno_list = [0, 1, 2, 4, 5]
self.dy_rel_lineno_list = [0, 2, 3, 5, 6]
Copy link
Member Author

@SigureMo SigureMo Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是与 node 开始处的相对行号(不含空行),因为 30 行处的 nested_func 格式化后中间多了一行(行号 1),所以从 [0, 1, 2, 4, 5] 变成了 [0, 2, 3, 5, 6](行号 1 之后都 +1)

@SigureMo SigureMo changed the title [WIP][CodeStyle] format some dy2static unittests [CodeStyle] format some dy2static unittests Sep 26, 2022
@luotao1 luotao1 self-assigned this Sep 27, 2022
@luotao1
Copy link
Contributor

luotao1 commented Sep 27, 2022

请更新下冲突

@luotao1
Copy link
Contributor

luotao1 commented Sep 27, 2022

这个PR不能用test=document_fix来跳过,需要跑一下单测

@SigureMo
Copy link
Member Author

这个PR不能用test=document_fix来跳过,需要跑一下单测

啊抱歉整错了 😂,没注意这个是改单测的 PR,已经重新触发全部 CI

@luotao1 luotao1 merged commit ee20334 into PaddlePaddle:develop Sep 28, 2022
@SigureMo SigureMo deleted the import/fix/future-test-error branch September 28, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants