Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle] add CI script to prevent future import #46466

Merged
merged 12 commits into from
Sep 27, 2022

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Sep 23, 2022

PR types

Others

PR changes

Others

Describe

添加脚本以阻止 from __future__ import xxx(除 annotations


@paddle-bot
Copy link

paddle-bot bot commented Sep 23, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Sep 23, 2022
@luotao1 luotao1 self-assigned this Sep 27, 2022
tools/check_file_diff_approvals.sh Outdated Show resolved Hide resolved
tools/check_file_diff_approvals.sh Outdated Show resolved Hide resolved
@@ -12,6 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from __future__ import annotations
from __future__ import generator_stop, print_function
from __future__ import annotations, print_function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这3行是为了做check用对么?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对的,需要测试下 Approve 的效果吗?不需要的话我就直接删掉了

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证通过,可以删除这3行了

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已移除

luotao1
luotao1 previously approved these changes Sep 27, 2022
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants