Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] [PHI] Migrate gelu kernels (#45596) #46728

Closed
wants to merge 2 commits into from
Closed

[cherry-pick] [PHI] Migrate gelu kernels (#45596) #46728

wants to merge 2 commits into from

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Oct 3, 2022

PR types

Others

PR changes

Others

Describe

  • migrate gelu FWD and BWD kernels to PHI,
  • cleanup fluid code,
  • remove unused macros.

@paddle-bot
Copy link

paddle-bot bot commented Oct 3, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 3, 2022
@Silv3S Silv3S added the Intel label Oct 3, 2022
@Silv3S
[PHI] Migrate gelu kernels (PaddlePaddle#45596)
b0f3b30 
* gaussian random

* mkldnn to onednn renaming

* fix merge conflicts

* remove fluid code

* onednn renaming

* gelu fwd

* sort activations

* gelu gradient

* remove unused macros

* merge conflicts

* fix merge conflicts

* remove extra contraint from gelu op
@Silv3S Silv3S mentioned this pull request Oct 3, 2022
Closed
@YuanRisheng
Copy link
Contributor

CI-Coverage is failed and you can cherry-pick #46621 in this PR for success

@Silv3S
Copy link
Member Author

Silv3S commented Oct 10, 2022

CI-Coverage is failed and you can cherry-pick #46621 in this PR for success

Thank you for the advice. Could you please help merging #46857? I will merge updated release/2.4 into this PR.

@Silv3S
Copy link
Member Author

Silv3S commented Oct 11, 2022 •
edited
Loading

Closing this PR, because gelu kernels were merged in #46862

@Silv3S Silv3S closed this Oct 11, 2022
@paddle-bot
Copy link

paddle-bot bot commented Oct 11, 2022

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@Silv3S Silv3S deleted the phi_5 branch October 11, 2022 13:13
@Silv3S
[PHI] transpose2_grad op migration (PaddlePaddle#46139)
60b60e9 
* op migrated, Copy(OneDNNContext, ...) added

* mutable_data & op registration in fluid removed

* refactoring

* OneDNNGetDataType to uppercase

* missing cpu check added, handler moved to .h file

* name changed to transpose_grad

* Copy changed back to TensorCopy

* Resizing corrected, Copy(OneDNNContext) removed
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Silv3S @YuanRisheng