Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle] remove all future import. #46736

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

Yulv-git
Copy link
Contributor

@Yulv-git Yulv-git commented Oct 3, 2022

PR types

Others

PR changes

Others

Describe

移除全部 from __future__ import xxx 结构,因为 Paddle 已经不支持 Python2.7 了。

future 详细说明见:https://docs.python.org/3/library/__future__.html。

Signed-off-by: Yulv-git <yulvchi@qq.com>
@paddle-bot
Copy link

paddle-bot bot commented Oct 3, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其余几个我看了下都是最近的增量……这增量出现的好快啊……

python/paddle/distributed/spawn.py Outdated Show resolved Hide resolved
tools/test_sampcd_processor.py Outdated Show resolved Hide resolved
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Oct 3, 2022
@luotao1 luotao1 merged commit 715b9d6 into PaddlePaddle:develop Oct 10, 2022
@SigureMo SigureMo deleted the import/fix/future-2 branch October 10, 2022 09:54
@luotao1
Copy link
Contributor

luotao1 commented Oct 11, 2022

image

@Yulv-git @SigureMo 还有4个文件7处

@SigureMo
Copy link
Member

@Yulv-git @SigureMo 还有4个文件7处

第一个文件是在 docstring 中的,因为示例代码问题跑不通在第一个修复 PR(#46411) 中 revert 了,这个我稍后单独提一个 PR

第二三个文件是增量,这两个暂不修改,先加入 TODOs 里,之后一起改

最后一个文件是需要 from __future__ import xxx 用来测试的,这个文件应该是不用改的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants