Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][F401] revert an import in sampcd_processor #46944

Merged

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Oct 12, 2022

PR types

Others

PR changes

Others

Describe

#46712 可能导致的示例代码无法运行,这里做下修复

  • 问题复现
  • 尝试修复
  • 恢复无关修改

related PRs: #46942#46938#45595#46943#45704 ...

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 12, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle][F401] revert an import in sampcd_processor [CodeStyle][F401] revert an import in sampcd_processor Oct 12, 2022
@@ -448,6 +448,8 @@ def get_filenames(full_test=False):

'''
global whl_error
import paddle # noqa: F401
import paddle.fluid.contrib.slim.quantization # noqa: F401
Copy link
Member Author

@SigureMo SigureMo Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

见上面 related PRs 里任意找一个 PR-CI-Static-Check 流水线:

image

#46712 移除了这些 import,导致 463 行的 eval 找不到 paddle

由于 #46712 没有修改英文文档,没有触发相关 CI,因此当时 CI 是通过的

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

由于本 PR 仅修改 tools/sampcd_processor.py,使用 test=document_fix 应该是安全的

@luotao1 luotao1 merged commit 67c9b0b into PaddlePaddle:develop Oct 12, 2022
@SigureMo SigureMo deleted the F401/fix/revert-sampcd-processor branch October 12, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants