Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hackathon No.10] Add unit tests for Normal #47070

Merged
merged 4 commits into from
Oct 25, 2022
Merged

[Hackathon No.10] Add unit tests for Normal #47070

merged 4 commits into from
Oct 25, 2022

Conversation

MayYouBeProsperous
Copy link
Contributor

@MayYouBeProsperous MayYouBeProsperous commented Oct 17, 2022 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

完成【Hackathon No.10】的TODO：为 paddle.distribution.Normal 类增加 rsample 的测试用例

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 17, 2022
@MayYouBeProsperous MayYouBeProsperous changed the title Add test for Noramal [Hackathon] Add test for Noramal Oct 17, 2022
@MayYouBeProsperous MayYouBeProsperous changed the title [Hackathon] Add test for Noramal [Hackathon] Add test for Normal Oct 18, 2022
@MayYouBeProsperous MayYouBeProsperous changed the title [Hackathon] Add test for Normal [Hackathon No.10] Add test for Normal Oct 18, 2022
@MayYouBeProsperous MayYouBeProsperous changed the title [Hackathon No.10] Add test for Normal [Hackathon No.10] Add uni他tests for Normal Oct 18, 2022
@MayYouBeProsperous MayYouBeProsperous changed the title [Hackathon No.10] Add uni他tests for Normal [Hackathon No.10] Add unit tests for Normal Oct 18, 2022
@luotao1 luotao1 requested a review from cxxly October 21, 2022 03:41
cxxly
cxxly reviewed Oct 21, 2022
View reviewed changes
python/paddle/fluid/tests/unittests/distribution/test_distribution_normal.py Outdated
scipy.stats.norm(loc=loc, scale=scale).cdf)
return ks < 0.02
def test_backpropagation(self):
paddle.grad([self.rsamples], [self.loc, self.scale])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert输出梯度形状和数据类型

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，已补充

cxxly
cxxly approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@cxxly cxxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 7e06541 into PaddlePaddle:develop Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@cxxly cxxly cxxly approved these changes

Assignees

@luotao1 luotao1

@cxxly cxxly

@Ligoml Ligoml

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MayYouBeProsperous @luotao1 @cxxly @Ligoml