Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added workaround for elementwise oneDNN kernel #47080

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Added workaround for elementwise oneDNN kernel #47080

merged 3 commits into from
Oct 25, 2022

Conversation

jakpiase
Copy link
Contributor

PR types

New features

PR changes

OPs

Describe

Added workaround for elementwise oneDNN kernel. It gets rid of "ref" implementations being called and improves U2++ int8 performance by ~6-7%.

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 17, 2022
@jakpiase jakpiase added Intel and removed contributor External developers status: proposed labels Oct 17, 2022
@jakpiase jakpiase requested a review from jczaja October 17, 2022 23:41
jczaja
jczaja previously approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja mentioned this pull request Oct 18, 2022
Open
zh794390558
zh794390558 previously approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yeliang2258
yeliang2258 previously approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@yeliang2258 yeliang2258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Oct 18, 2022
jczaja
jczaja previously approved these changes Oct 24, 2022
View reviewed changes
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ 0x45f
✅ yeliang2258
✅ zh794390558
✅ Silv3S
✅ jakpiase
❌ root

root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

jczaja
jczaja approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit 0abf756 into PaddlePaddle:develop Oct 25, 2022
@paddle-bot
Copy link

paddle-bot bot commented Oct 25, 2022

你的PR已合入Paddle库，请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

@yeliang2258 yeliang2258 mentioned this pull request Oct 26, 2022
Merged
ZeyuChen pushed a commit that referenced this pull request Oct 26, 2022
@yeliang2258 @jakpiase
Added workaround for elementwise oneDNN kernel (#47080) (#47342)
7c6550a 
* return proper state

* fix for dims

* fix

Co-authored-by: jakpiase <jakpia21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczaja jczaja jczaja approved these changes

@zh794390558 zh794390558 zh794390558 left review comments

@yeliang2258 yeliang2258 yeliang2258 left review comments

Assignees
No one assigned
Labels
contributor External developers Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakpiase @CLAassistant @zh794390558 @jczaja @yeliang2258