Move the logic of mkldnn layout in GetKernelTypeForVar from ActivationOp to OperatorWithKernel #47104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nOp to base class
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
approved these changes
Oct 18, 2022
jiahy0825
reviewed
Oct 18, 2022
| // When the op is first oneDNN op (there was some non oneDNN op | ||
| // previously) | ||
| // then we also need to rotate shape NHWC -> NCWH | ||
| if ((expected_kernel_type.data_layout_ == phi::DataLayout::kMKLDNN) && |
There was a problem hiding this comment.
此处兼容其他 op 吗？很多 mkldnn op 的 GetKernelTypeForVar 函数中，并没有这部分代码
Do other ops compatible with the code here? Many mkldnn ops do not contain these codes.
There was a problem hiding this comment.
根据PR39097中的comment来看，这应该是一个通用的逻辑，具体是否有影响可能需要CE模型测试做进一步验证
jiahy0825
approved these changes
Oct 18, 2022
chenwhql
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
将
ActivationOp的GetKernelTypeForVar中对于 mkldnn layout的处理逻辑移动到基类OperatorWithKernel中。主要目的是为了规范Op定义的相关代码，以便于通过Yaml完成对应代码逻辑的生成。