Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zero-Dim] support input 0D Tensor for sum/mean/nan_sum/nan_mean #47219

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[Zero-Dim] support input 0D Tensor for sum/mean/nan_sum/nan_mean #47219

merged 1 commit into from
Oct 31, 2022

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Oct 20, 2022 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

[Zero-Dim] support input 0D Tensor for sum/mean/nan_sum/nan_mean:

为以下API支持输入0D Tensor，不修改其输出端行为，属于新增功能，无不兼容影响：

paddle.sum
paddle.mean
paddle.nan_sum
paddle.nan_mean

@zhwesky2010 zhwesky2010 force-pushed the 0D_sum_mean branch 5 times, most recently from 4177326 to 2c319f4 Compare October 21, 2022 04:01
@zhwesky2010 zhwesky2010 changed the title [Zero-Dim] support input 0D Tensor for reduce_sum/mean/randint/softmax [Zero-Dim] support input 0D Tensor for reduce_sum/mean/softmax Oct 21, 2022
@zhwesky2010 zhwesky2010 changed the title [Zero-Dim] support input 0D Tensor for reduce_sum/mean/softmax [Zero-Dim] support input 0D Tensor for reduce_sum/reduce_mean/softmax Oct 21, 2022
@zhwesky2010 zhwesky2010 changed the title [Zero-Dim] support input 0D Tensor for reduce_sum/reduce_mean/softmax [Zero-Dim] support input 0D Tensor for reduce_sum/reduce_mean Oct 24, 2022
@zhwesky2010 zhwesky2010 force-pushed the 0D_sum_mean branch 7 times, most recently from 9480bb9 to 2fde5cd Compare October 26, 2022 11:31
jeff41404
jeff41404 reviewed Oct 27, 2022
View reviewed changes
python/paddle/fluid/tests/unittests/test_zero_dim_shape.py Outdated
Comment on lines 168 to 169
paddle.fluid.layers.reduce_sum,
paddle.fluid.layers.reduce_mean,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API of paddle.fluid will be removed soon, no need add to test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zhwesky2010 zhwesky2010 force-pushed the 0D_sum_mean branch 8 times, most recently from 903bc51 to abfa4c5 Compare October 28, 2022 12:20
jeff41404
jeff41404 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit c8fc337 into PaddlePaddle:develop Oct 31, 2022
@zhwesky2010 zhwesky2010 changed the title [Zero-Dim] support input 0D Tensor for reduce_sum/reduce_mean [Zero-Dim] support input 0D Tensor for sum/mean/nan_sum/nan_mean Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhwesky2010 @jeff41404