Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix The first round of evaluation #47256

Merged
merged 25 commits into from
Nov 9, 2022
Merged

Conversation

CodeNTrade2025
Copy link
Contributor

@CodeNTrade2025 CodeNTrade2025 commented Oct 21, 2022

PR types

Others

PR changes

Docs

Describe

fix The first round of evaluation

Chinese and English return values are inconsistent
把函数的输出改成正确的
增加了一个unbiased=False的代码示例,没有增加numpy,怕引起误会。
只把代码拆分了5段
@paddle-bot
Copy link

paddle-bot bot commented Oct 21, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -837,6 +837,7 @@ def load(path, **configs):

Examples:
.. code-block:: python
:name: code-example-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要同步修改中文文档,
COPY-FROM: paddle.load:code-example-1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle.save也是相同的问题,一起改了吧~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文文档好像有一些note也没有翻译

@@ -186,35 +186,35 @@ def matmul(x, y, transpose_x=False, transpose_y=False, name=None):
y = paddle.rand([10])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle.matmul的问题主要在于:
英文文档:transpose_x=False, transpose_y=False, name=None,这三个都是可选参数,需要在参数描述的部分注明 optional
中文文档:参数介绍的部分,: --> -

Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@luotao1 luotao1 merged commit 0a05129 into PaddlePaddle:develop Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants