Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI] Migrate pool2d and pool2d_grad kernels #47423

Merged
merged 48 commits into from
Nov 4, 2022
Merged

[PHI] Migrate pool2d and pool2d_grad kernels #47423

merged 48 commits into from
Nov 4, 2022

Conversation

piotrekobi
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Migrates the following oneDNN operator fluid kernels to PHI:

  • pool2d
  • pool2d_grad

chenwhql and others added 30 commits September 20, 2022 11:20
@chenwhql
add extra attr property set
00c2aca
@chenwhql
add type_info for all context
28e9710
@chenwhql
add onednn context to all context
cd630f0
@chenwhql
fix context compile error
d633672
@chenwhql
simplify conv kernel args
d651bf9
@chenwhql
pass runtime attr into dev_ctx
84c56fa
@chenwhql
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
24ea5b4 
… adapto_extra_attr_in_phi
@chenwhql
fix marco error
fc67372
@chenwhql
clear conv_grad_kernel extra args
ed7b59f
@chenwhql
merge conv_grad_grad into conv_grad
23cab07
@chenwhql
clear conv2d_grad_grad extra attrs
123edd2
@chenwhql
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
d29a519 
… adapto_extra_attr_in_phi
@chenwhql
clear yaml and eager extra attr
853b1db
@chenwhql
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
62ce48b 
… adapto_extra_attr_in_phi
@chenwhql
fix conv1d error
de52450
@chenwhql
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
2c55350 
… adapto_extra_attr_in_phi
@chenwhql
change to thread local
03f6893
@chenwhql
fix npu compile failed
49bcebe
@chenwhql
try to fix windows compile failed
ada7d0c
@chenwhql
add conv2d onednn phi kernel
22ccfa9
@chenwhql
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
9602334 
… adapto_extra_attr_in_phi
@YuanRisheng
fix ci bugs (PaddlePaddle#36)
6331512
@YuanRisheng
fix compile bugs (PaddlePaddle#38)
37afcf6
@YuanRisheng
fix extra input transform bug (PaddlePaddle#39)
39e2529
@YuanRisheng
support dynamic created attr (PaddlePaddle#40)
16d595c
@chenwhql
resolve conflict with develop
0d61412
@chenwhql
Merge branch 'adapto_extra_attr_in_phi' of https://github.com/chenwhq…
722b256 
…l/Paddle into adapto_extra_attr_in_phi
@chenwhql
resolve conflict with develop
8d59887
@chenwhql
reset extra info gen code
c0cdb15
@chenwhql
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
42bc76b 
… adapto_extra_attr_in_phi
@paddle-bot
Copy link

paddle-bot bot commented Oct 27, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 27, 2022
@piotrekobi piotrekobi marked this pull request as draft October 27, 2022 15:35
@piotrekobi piotrekobi marked this pull request as ready for review November 2, 2022 09:55
@Silv3S Silv3S mentioned this pull request Nov 2, 2022
Closed
YuanRisheng
YuanRisheng previously approved these changes Nov 3, 2022
View reviewed changes
Silv3S
Silv3S previously approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@Silv3S Silv3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddle/fluid/operators/mkldnn/test_mkldnn_op_nhwc.cc Outdated Show resolved Hide resolved
@piotrekobi @Silv3S
Update paddle/fluid/operators/mkldnn/test_mkldnn_op_nhwc.cc
19bd42b 
Co-authored-by: Sławomir Siwek <slawomir.siwek@intel.com>
piotrekobi and others added 2 commits November 3, 2022 12:38
@piotrekobi @Silv3S
Update paddle/phi/kernels/onednn/pool_grad_kernel.cc
0d4e6d7 
Co-authored-by: Sławomir Siwek <slawomir.siwek@intel.com>
@piotrekobi @Silv3S
Update paddle/phi/kernels/onednn/pool_kernel.cc
ee81173 
Co-authored-by: Sławomir Siwek <slawomir.siwek@intel.com>
@YuanRisheng YuanRisheng merged commit ca4bed7 into PaddlePaddle:develop Nov 4, 2022
sfraczek
sfraczek reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@sfraczek sfraczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfraczek sfraczek sfraczek left review comments

@Silv3S Silv3S Silv3S left review comments

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@chenwhql chenwhql Awaiting requested review from chenwhql

Assignees
No one assigned
Labels
contributor External developers Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@piotrekobi @sfraczek @YuanRisheng @Silv3S @chenwhql