[PHI decoupling] Move fluid op generator into fluid #47714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
previously approved these changes
Nov 8, 2022
zyfncg
previously approved these changes
Nov 8, 2022
Comment on lines
205
to
207
| if(NOT PYTHONINTERP_FOUND) | ||
| find_package(PythonInterp REQUIRED) | ||
| endif() |
zyfncg
approved these changes
Nov 9, 2022
jiahy0825
approved these changes
Nov 9, 2022
YuanRisheng
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[PHI decoupling] Move fluid op generator into fluid
为什么需要移动这部分代码？
op生成工具的代码include了fluid中的文件，需要移出去
PHI中的算子定义是配置式的，设计上是希望各执行架构结合自己的需求，基于同一套配置式算子定义，生成自己的算子实现，因此各执行架构的算子生成代码需要在各自目录体系中：
phi/ops/compat目录下的sig.cc按理说也应该移到fluid，但这些除了给fluid用，也在给infrt用，infrt是不能依赖fluid的，所以暂时不移动，后面是否移动需要看infrt后续的规划