[CodeStyle][F821] fix test_exception in test_unpool3d_op and test_unpool_op #47756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
SigureMo
changed the title
SigureMo
commented
Nov 8, 2022
| ValueError, | ||
| r"index should less than output", | ||
| indices_value_error, | ||
| ) |
There was a problem hiding this comment.
GPU 是没有这个报错的，因此这里仅在 CPU assert
| paddle.disable_static() | ||
|
|
||
| def tearDown(self): | ||
| paddle.enable_static() |
There was a problem hiding this comment.
test_exception 使用动态图进行测试
This was referenced Nov 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
在查看 F821 已有问题时发现的，修复了一下这两个单测，算是顺带修复了几个 F821 问题（75 个 -> 70 个，修复了 5 个，剩余很多，需要之后慢慢修）
这两个单测 assertRaises ValueError 都是
paddle.randint(shape=[1, 1, 3, 3, 3])报的（randint 需要传入 low、high），而不是需要测试的 API/OP（F.max_unpool2d）报的（名字都写成F.maxunpool2d了，肯定不是他报的……），因此将其余部分改对（除此之外错误还有不少……），使 ValueError 确实在需要测试的 API 报错为了确保这一点，使用 assertRaisesRegex 代替了 assertRaises，这样能对 Error 的 message 有一个约束，可以确保是需要的那个错误
Related links
namecattidea/paddle-flake8-project#79