Add MultivariateNormal distribution API #47825

dasenCoding · 2022-11-10T02:17:04Z

PR types

New features

PR changes

APIs

Describe

新增 MultivariateNormal 分布API
设计文档：PaddlePaddle/community#320
中文api文档：PaddlePaddle/docs#5551

paddle-bot · 2022-11-10T02:17:08Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

luotao1 · 2022-11-14T06:51:17Z

@dasenCoding 请解决下冲突

dasenCoding · 2022-11-14T09:18:14Z

@dasenCoding 请解决下冲突

冲突已解决。
抱歉，处理冲突还不熟练，耽搁时间久了点。

…into multnormal_api

luotao1 · 2022-11-28T08:38:46Z

2022-11-25 10:56:24 Your PR code style check failed.
2022-11-25 10:56:24 Please install pre-commit locally and set up git hook scripts:
2022-11-25 10:56:24 
2022-11-25 10:56:24     pip install pre-commit==2.17.0
2022-11-25 10:56:24     pre-commit install
2022-11-25 10:56:24 
2022-11-25 10:56:24 Then, run pre-commit to check codestyle issues in your PR:
2022-11-25 10:56:24 
2022-11-25 10:56:24     pre-commit run --files python/paddle/distribution/kl.py python/paddle/distribution/multivariate_normal.py
2022-11-25 10:56:24

PR-CI-Codestyle-Check 流水线没有过，请按照提示修改下代码格式。

dasenCoding · 2022-11-30T02:29:23Z

2022-11-25 10:56:24 Your PR code style check failed.
2022-11-25 10:56:24 Please install pre-commit locally and set up git hook scripts:
2022-11-25 10:56:24 
2022-11-25 10:56:24     pip install pre-commit==2.17.0
2022-11-25 10:56:24     pre-commit install
2022-11-25 10:56:24 
2022-11-25 10:56:24 Then, run pre-commit to check codestyle issues in your PR:
2022-11-25 10:56:24 
2022-11-25 10:56:24     pre-commit run --files python/paddle/distribution/kl.py python/paddle/distribution/multivariate_normal.py
2022-11-25 10:56:24

PR-CI-Codestyle-Check 流水线没有过，请按照提示修改下代码格式。

好的，感谢！但api 部分代码还未完成，可能需要完成后再整体修改代码格式。

paddle-bot · 2022-12-04T05:17:49Z

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

…into multnormal_api

luotao1 · 2022-12-20T04:06:10Z

PR 如果可以 review 了，请@我

…into multnormal_api

luotao1 · 2023-01-10T03:40:17Z

Coverage流水线中的test_dygraph_sharding_stage3_for_eager (Failed)是随机挂，可以忽略。请问这个 PR 可以进入 review 环节了么？ @dasenCoding

dasenCoding · 2023-01-10T04:00:10Z

Coverage流水线中的test_dygraph_sharding_stage3_for_eager (Failed)是随机挂，可以忽略。请问这个 PR 可以进入 review 环节了么？ @dasenCoding

API 已经完成了，除了您刚才提到的 Coverage，有两个CI 检查没有通过，需要全部通过再进行 review 吗？

luotao1 · 2023-01-10T04:16:57Z

API 已经完成了，除了您刚才提到的 Coverage，有两个CI 检查没有通过，需要全部通过再进行 review 吗？

不用，PR-CI-Static-Check是需要approve的，PR-CI-Build-ALLFramework-Compile是非required流水线，可以暂时不用关注。

请 @cxxly 可以帮忙 review 了～

dasenCoding · 2023-01-10T06:34:20Z

API 已经完成了，除了您刚才提到的 Coverage，有两个CI 检查没有通过，需要全部通过再进行 review 吗？

不用，PR-CI-Static-Check是需要approve的，PR-CI-Build-ALLFramework-Compile是非required流水线，可以暂时不用关注。

请 @cxxly 可以帮忙 review 了～

好的，谢谢哈！

dasenCoding · 2023-01-10T06:35:07Z

@cxxly 麻烦您 review 一下。

cxxly · 2023-01-13T09:58:56Z

python/paddle/distribution/multivariate_normal.py

+
+    def __init__(self, loc, covariance_matrix):
+        if loc.dim() < 1:
+            raise ValueError("loc must be at least one-dimensional.")


len(loc.shape)

cxxly · 2023-01-13T10:02:05Z

python/paddle/distribution/multivariate_normal.py

+        if loc.dim() < 1:
+            raise ValueError("loc must be at least one-dimensional.")
+        if (covariance_matrix is not None) != 1:
+            raise ValueError("Exactly covariance_matrix may be specified.")


if (covariance_matrix is not None) != 1 这句话的语义是？ if covariance_matrix is None ?

对，是 if covariance_matrix is None 的意思。

cxxly · 2023-01-13T10:04:43Z

python/paddle/distribution/multivariate_normal.py

+            return paddle.reshape(reshaped_M, bx_batch_shape)
+
+    def _extend_shape(self, sample_shape):
+        """Compute shape of the sample


基类中应该有这个方法，复用下

cxxly · 2023-01-13T10:07:30Z

参考已有分布，补充单测

dasenCoding · 2023-01-13T12:37:32Z

参考已有分布，补充单测

好的。

…into multnormal_api

luotao1 · 2023-02-01T03:36:13Z

@dasenCoding 请解决下Coverage流水线单测覆盖率不足的问题

dasenCoding · 2023-02-01T04:51:55Z

@dasenCoding 请解决下Coverage流水线单测覆盖率不足的问题

好的！

dropout2d; test=document_fix

8d99219

paddle-bot bot added contributor External developers status: proposed labels Nov 10, 2022

init multivariate_normal api

23e7ebd

luotao1 assigned luotao1 and cxxly Nov 10, 2022

dasenCoding added 3 commits November 14, 2022 15:46

resolve conflicts

be5d83f

resolve conflicts

1b156d7

rollback kl.py

5a90ff0

dasenCoding and others added 4 commits November 14, 2022 17:21

Merge branch 'PaddlePaddle:develop' into multnormal_api

3de0a18

Merge branch 'PaddlePaddle:develop' into multnormal_api

006d08a

update: init / mean / variance / stddev

29b0578

Merge branch 'multnormal_api' of https://github.com/dasenCoding/Paddle …

30c925e

…into multnormal_api

dasenCoding closed this Dec 4, 2022

dasenCoding force-pushed the multnormal_api branch from 30c925e to 4552be4 Compare December 4, 2022 05:17

paddle-bot bot added status: not progressed and removed status: proposed labels Dec 4, 2022

dasenCoding added 2 commits December 4, 2022 16:41

fix: deal conflict

9ffdadb

Merge branch 'multnormal_api' of https://github.com/dasenCoding/Paddle …

622c335

…into multnormal_api

dasenCoding reopened this Dec 4, 2022

dasenCoding and others added 3 commits December 18, 2022 10:23

Merge branch 'PaddlePaddle:develop' into multnormal_api

972e19c

update prob / log_prob

653793d

update entrop / sample / rsample

89168bf

dasenCoding and others added 4 commits January 1, 2023 13:20

Merge branch 'multnormal_api' of https://github.com/dasenCoding/Paddle …

091c0dd

…into multnormal_api

fix code-style

3bb3526

fix code-style

de92b38

Merge branch 'PaddlePaddle:develop' into multnormal_api

1082433

cxxly reviewed Jan 13, 2023

View reviewed changes

dasenCoding and others added 9 commits January 14, 2023 01:04

Merge branch 'PaddlePaddle:develop' into multnormal_api

d75b351

fix dim to len

06bbd2a

Merge branch 'multnormal_api' of https://github.com/dasenCoding/Paddle …

95935db

…into multnormal_api

Merge branch 'PaddlePaddle:develop' into multnormal_api

4360f90

delete extend_shape method

683c85d

Merge branch 'multnormal_api' of https://github.com/dasenCoding/Paddle …

6c3d291

…into multnormal_api

fix code style

3809fb4

fix dim

04e12f5

Merge branch 'PaddlePaddle:develop' into multnormal_api

465b6c0

Merge branch 'PaddlePaddle:develop' into multnormal_api

215e48e

luotao1 added the API label May 9, 2023

paddle-bot bot removed the status: not progressed label May 9, 2023

dasenCoding mentioned this pull request Jun 9, 2023

黑客松挑战性任务列表 #48022

Closed

luotao1 closed this Mar 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MultivariateNormal distribution API #47825

Add MultivariateNormal distribution API #47825

dasenCoding commented Nov 10, 2022 •

edited

Loading

paddle-bot bot commented Nov 10, 2022

luotao1 commented Nov 14, 2022

dasenCoding commented Nov 14, 2022 •

edited

Loading

luotao1 commented Nov 28, 2022

dasenCoding commented Nov 30, 2022 •

edited

Loading

paddle-bot bot commented Dec 4, 2022

luotao1 commented Dec 20, 2022

luotao1 commented Jan 10, 2023

dasenCoding commented Jan 10, 2023

luotao1 commented Jan 10, 2023

dasenCoding commented Jan 10, 2023

dasenCoding commented Jan 10, 2023 •

edited

Loading

cxxly Jan 13, 2023

cxxly Jan 13, 2023

dasenCoding Jan 13, 2023

cxxly Jan 13, 2023

dasenCoding Jan 13, 2023

cxxly commented Jan 13, 2023

dasenCoding commented Jan 13, 2023

luotao1 commented Feb 1, 2023

dasenCoding commented Feb 1, 2023

Add MultivariateNormal distribution API #47825

Add MultivariateNormal distribution API #47825

Conversation

dasenCoding commented Nov 10, 2022 • edited Loading

PR types

PR changes

Describe

paddle-bot bot commented Nov 10, 2022

luotao1 commented Nov 14, 2022

dasenCoding commented Nov 14, 2022 • edited Loading

luotao1 commented Nov 28, 2022

dasenCoding commented Nov 30, 2022 • edited Loading

paddle-bot bot commented Dec 4, 2022

luotao1 commented Dec 20, 2022

luotao1 commented Jan 10, 2023

dasenCoding commented Jan 10, 2023

luotao1 commented Jan 10, 2023

dasenCoding commented Jan 10, 2023

dasenCoding commented Jan 10, 2023 • edited Loading

cxxly Jan 13, 2023

Choose a reason for hiding this comment

cxxly Jan 13, 2023

Choose a reason for hiding this comment

dasenCoding Jan 13, 2023

Choose a reason for hiding this comment

cxxly Jan 13, 2023

Choose a reason for hiding this comment

dasenCoding Jan 13, 2023

Choose a reason for hiding this comment

cxxly commented Jan 13, 2023

dasenCoding commented Jan 13, 2023

luotao1 commented Feb 1, 2023

dasenCoding commented Feb 1, 2023

dasenCoding commented Nov 10, 2022 •

edited

Loading

dasenCoding commented Nov 14, 2022 •

edited

Loading

dasenCoding commented Nov 30, 2022 •

edited

Loading

dasenCoding commented Jan 10, 2023 •

edited

Loading