Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] remove "paddle/fluid/operators/amp/fp16_type_traits.h" in phi #48051

Merged
merged 3 commits into from
Nov 18, 2022
Merged

[PHI decoupling] remove "paddle/fluid/operators/amp/fp16_type_traits.h" in phi #48051

merged 3 commits into from
Nov 18, 2022
+15 −15

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented Nov 16, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

remove "paddle/fluid/operators/amp/fp16_type_traits.h" in phi

changes:

  • replace #include "paddle/fluid/operators/amp/fp16_type_traits.h" by #include "paddle/phi/common/amp_type_traits.h" and replace paddle::operators::details::MPTypeTrait by phi::dtype::MPTypeTrait in relevant files.

@paddle-bot
Copy link

paddle-bot bot commented Nov 16, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 16, 2022
@GreatV GreatV mentioned this pull request Nov 16, 2022
Closed
@huangjiyi
Copy link
Member Author

@ZzSean，帮忙看一下 OP-benchmark 的问题

@huangjiyi
Copy link
Member Author

@luotao1 , @YuanRisheng

@luotao1
Copy link
Contributor

luotao1 commented Nov 17, 2022

@YuanRisheng 除了 Op-benchmark 外，其余 CI 都已经过了，可以先进行 review

YuanRisheng
YuanRisheng previously approved these changes Nov 17, 2022
View reviewed changes
@huangjiyi
Copy link
Member Author

huangjiyi commented Nov 17, 2022 •
edited
Loading

Conflict resolved.

@huangjiyi
Copy link
Member Author

@YuanRisheng ，麻烦再 review 一下

@huangjiyi
Copy link
Member Author

@ZzSean , 帮忙看下 OP-benchmark 的问题

ZzSean
ZzSean approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

@luotao1 luotao1 merged commit e4670d8 into PaddlePaddle:develop Nov 18, 2022
@huangjiyi huangjiyi deleted the decouple_fp16_type_utils_h branch December 9, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@ZzSean ZzSean ZzSean approved these changes

Assignees

@luotao1 luotao1

@YuanRisheng YuanRisheng

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huangjiyi @luotao1 @YuanRisheng @ZzSean