Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge][CodeStyle][pyupgrade] automatically rewrite code with pyupgrade #48140

Closed
wants to merge 4 commits into from

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Nov 18, 2022

PR types

Others

PR changes

Others

Describe

https://github.com/asottile/pyupgrade

尝试使用 pyupgrade 以各种配置(--py3-plus--py36-plus--py37-plus)对全量代码格式化,目前只是测试

可能的问题:动转静单测 case 不能重写的某些场景(不过目前还没发现相关 case)

  • --py3-plus(495 文件)
  • --py36-plus(431 文件)
  • --py37-plus(0 文件)

TODO:逐一查看需要 approve 的条目

@paddle-bot
Copy link

paddle-bot bot commented Nov 18, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 18, 2022
@SigureMo SigureMo changed the title [CodeStyle][pyupgrade] automatically rewrite code with pyupgrade [Don't merge][CodeStyle][pyupgrade] automatically rewrite code with pyupgrade Nov 18, 2022
@luotao1 luotao1 self-assigned this Nov 18, 2022
@luotao1
Copy link
Contributor

luotao1 commented Nov 21, 2022

TODO:逐一查看需要 approve 的条目

流水线中approve条目我看了都没什么问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants