Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI] Migrate elementwise_div + all elementwise grad kernels #48210

Merged
merged 2 commits into from
Nov 22, 2022
Merged

[PHI] Migrate elementwise_div + all elementwise grad kernels #48210

merged 2 commits into from
Nov 22, 2022

Conversation

piotrekobi
Copy link
Contributor

@piotrekobi piotrekobi commented Nov 21, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Migrates the following oneDNN fluid kernels to PHI:

  • elementwise_div
  • elementwise_add_grad
  • elementwise_sub_grad
  • elementwise_mul_grad
  • elementwise_div_grad

@paddle-bot
Copy link

paddle-bot bot commented Nov 21, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 21, 2022
@piotrekobi piotrekobi force-pushed the elementwise_sub_mul_div_migration branch from 596850f to b6c01bb Compare November 21, 2022 12:57
@piotrekobi piotrekobi changed the title Migrate elementwise sub, mul and div fluid kernels to PHI [PHI] Migrate elementwise_div kernel Nov 21, 2022
@piotrekobi piotrekobi changed the title [PHI] Migrate elementwise_div kernel [PHI] Migrate elementwise_div + all elementwise grad kernels Nov 21, 2022
@Silv3S Silv3S mentioned this pull request Nov 21, 2022
Closed
@Silv3S Silv3S self-requested a review November 21, 2022 20:21
Silv3S
Silv3S approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@Silv3S Silv3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng
Copy link
Contributor

It seems that CI-Coverage detects low code coverage. ElementwiseKernel in elementwise_kernel.cc is not exercised. You can check it on your machine by running unittest. If the code modified is exercised. I will mark it as successful. Thank you.

@piotrekobi
Copy link
Contributor Author

It seems that CI-Coverage detects low code coverage. ElementwiseKernel in elementwise_kernel.cc is not exercised. You can check it on your machine by running unittest. If the code modified is exercised. I will mark it as successful. Thank you.

I checked with a Python unit test and the kernel is ran properly.

@Silv3S Silv3S requested a review from jczaja November 22, 2022 13:47
@jczaja jczaja merged commit 78b30e9 into PaddlePaddle:develop Nov 22, 2022
@paddle-bot
Copy link

paddle-bot bot commented Nov 22, 2022

你的PR已合入Paddle库，请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@Silv3S Silv3S Silv3S approved these changes

@jczaja jczaja Awaiting requested review from jczaja

Assignees

@iclementine iclementine

Labels
contributor External developers Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@piotrekobi @YuanRisheng @Silv3S @jczaja @iclementine