Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] Move MKLDNN code #48352

Merged
merged 20 commits into from
Nov 29, 2022
Merged

[PHI decoupling] Move MKLDNN code #48352

merged 20 commits into from
Nov 29, 2022

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Nov 24, 2022 •
edited by luotao1
Loading

PR types

Others

PR changes

Others

Describe

@paddle-bot
Copy link

paddle-bot bot commented Nov 24, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 24, 2022
@Silv3S Silv3S marked this pull request as ready for review November 24, 2022 18:32
@Silv3S Silv3S changed the title [PHI] Migrate transpose2 kernel [PHI decoupling] Move MKLDNN code Nov 25, 2022
@Silv3S Silv3S added the Intel label Nov 25, 2022
@luotao1
Copy link
Contributor

luotao1 commented Nov 28, 2022

@YuanRisheng Please review this PR

YuanRisheng
YuanRisheng previously approved these changes Nov 28, 2022
View reviewed changes
XiaoguangHu01
XiaoguangHu01 previously approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Nov 28, 2022

Please solve the conflict @Silv3S

iclementine
iclementine approved these changes Nov 28, 2022
View reviewed changes
Copy link

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit fa051ee into PaddlePaddle:develop Nov 29, 2022
@Silv3S Silv3S deleted the phi_transpose2_kernel branch November 29, 2022 06:39
@Silv3S Silv3S mentioned this pull request Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclementine iclementine iclementine approved these changes

@YuanRisheng YuanRisheng YuanRisheng left review comments

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 left review comments

Assignees

@luotao1 luotao1

@iclementine iclementine

@YuanRisheng YuanRisheng

Labels
contributor External developers Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Silv3S @luotao1 @iclementine @YuanRisheng @XiaoguangHu01