[PHI decoupling] move several header files from fluid to phi #48415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
huangjiyi
commented
Nov 27, 2022
Comment on lines
+23
to
24
| #include "paddle/fluid/memory/memory.h" | ||
| #include "paddle/phi/backends/gpu/gpu_context.h" |
There was a problem hiding this comment.
这里引入了 fluid 下的 memory.h 是因为这个文件通过 gpu_dnn.h 依赖了 memory.h，而 phi 下的 gpu_dnn.h 已经移除了对 memory.h 的依赖，而且只有这一个文件，所以我就在这里加了 memory.h，因为这样可以在后续处理 memory.h 的时候一起处理掉，更方便一些。
|
@YuanRisheng ，帮忙 review 一下 |
|
@luotao1, @XiaoguangHu01 , @ZzSean 帮忙处理一下失败的 CI |
|
@luotao1 ，PR-CI-APPROVAL 里还有需要您帮忙处理的问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
cuda/cudnn_desc.h、cuda/cudnn_helper.h、rocm/miopen_desc.h、rocm/miopen_helper.h、gpu_dnn.h从paddle/fluid/platform/device/gpu/目录移动至paddle/phi/backends/gpu目录.fluid目录下还有很多文件依赖gpu_dnn.h，所以没有移除fluid下的gpu_dnn.h，同时这些文件通过gpu_dnn.h对cuda/cudnn_helper.h和rocm/miopen_helper.h的依赖则通过在gpu_dnn.h中使用using处理了。