-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace LoDTensor with phi::DenseTensor in fluid\operators #48417
Replace LoDTensor with phi::DenseTensor in fluid\operators #48417
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
// The output phi::DenseTensor's lod_level should be input X's lod_level | ||
// - 1. For compile time, we call SetLoDLevel to set output's lod_level. For | ||
// runtime, output phi::DenseTensor's lod is determined by input X's lod and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个注释是不是需要再调整一下,和之前相比换行有点错乱了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不太建议调整,因为这样符合代码规范。(这个地方的格式应该是被pre-commit修改的,我应该没有操作过这里)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…dle#48417) * replace LoDTensor with phi::DenseTensor in fluid\operators * replace LoDTensor with phi::DenseTensor in fluid\operators * Update split_lod_tensor_op.cc * Update warpctc_op.cc * Update broadcast_tensors_op.cc * Update crf_decoding_op.cc * Update lstm_op.cc * Update lstm_op.cc * Update lod_reset_op.cc * Update gru_op.cc * Update linear_chain_crf_op.cc * resume 2 files for confilct * Update gru_op.cc * Update linear_chain_crf_op.cc * Update lstm_op.cc
PR types
Others
PR changes
Others
Describe
Replace LoDTensor with phi::DenseTensor in fluid\operators
Related links