Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LoDTensor with phi::DenseTensor in fluid\operators #48417

Merged
merged 16 commits into from
Nov 29, 2022

Conversation

@paddle-bot
Copy link

paddle-bot bot commented Nov 27, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 27, 2022
Comment on lines +238 to +240
// The output phi::DenseTensor's lod_level should be input X's lod_level
// - 1. For compile time, we call SetLoDLevel to set output's lod_level. For
// runtime, output phi::DenseTensor's lod is determined by input X's lod and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个注释是不是需要再调整一下,和之前相比换行有点错乱了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不太建议调整,因为这样符合代码规范。(这个地方的格式应该是被pre-commit修改的,我应该没有操作过这里)

paddle/fluid/operators/split_lod_tensor_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/broadcast_tensors_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/crf_decoding_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/crf_decoding_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/gru_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/linear_chain_crf_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/linear_chain_crf_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/lod_reset_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/lstm_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/warpctc_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/warpctc_op.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 91dd8a2 into PaddlePaddle:develop Nov 29, 2022
@Liyulingyue Liyulingyue deleted the DensorTensor_operator branch November 29, 2022 11:35
lxsbupt pushed a commit to lxsbupt/Paddle that referenced this pull request Dec 17, 2022
…dle#48417)

* replace LoDTensor with phi::DenseTensor in fluid\operators

* replace LoDTensor with phi::DenseTensor in fluid\operators

* Update split_lod_tensor_op.cc

* Update warpctc_op.cc

* Update broadcast_tensors_op.cc

* Update crf_decoding_op.cc

* Update lstm_op.cc

* Update lstm_op.cc

* Update lod_reset_op.cc

* Update gru_op.cc

* Update linear_chain_crf_op.cc

* resume 2 files for confilct

* Update gru_op.cc

* Update linear_chain_crf_op.cc

* Update lstm_op.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants