Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zero-Dim] Scatter gather 0d support #48452

Merged
merged 2 commits into from
Dec 3, 2022
Merged

[Zero-Dim] Scatter gather 0d support #48452

merged 2 commits into from
Dec 3, 2022

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Nov 28, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Scatter gather 0d support

XPU UT

image

NPU/MLU PR

PaddlePaddle/PaddleCustomDevice#243

Chinese doc PR

PaddlePaddle/docs#5479

@paddle-bot
Copy link

paddle-bot bot commented Nov 28, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FeixLiu FeixLiu mentioned this pull request Nov 29, 2022
Merged
@FeixLiu FeixLiu force-pushed the scatter_gather_0d_support branch 2 times, most recently from 6bdf5da to a52f545 Compare December 1, 2022 00:20
@FeixLiu FeixLiu force-pushed the scatter_gather_0d_support branch 2 times, most recently from 13b310f to 9c21af0 Compare December 1, 2022 11:57
@FeixLiu
CPU, GPU and XPU support 0D index for gather.
3e826e0 
CPU, GPU and XPU support 0D index and 0D updates for scatter.
zhwesky2010
zhwesky2010 reviewed Dec 2, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API文档也改下吧
infoflow 2022-12-02 17-09-16
infoflow 2022-12-02 17-12-40

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py Show resolved Hide resolved
zhwesky2010
zhwesky2010 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ligoml
Ligoml approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs，中文文档也同步更新一下吧

@FeixLiu FeixLiu merged commit f9815bf into PaddlePaddle:develop Dec 3, 2022
@FeixLiu FeixLiu deleted the scatter_gather_0d_support branch December 6, 2022 10:29
@zhwesky2010 zhwesky2010 changed the title Scatter gather 0d support [Zero-Dim] Scatter gather 0d support Dec 6, 2022
lxsbupt pushed a commit to lxsbupt/Paddle that referenced this pull request Dec 17, 2022
@FeixLiu
Scatter 0D index for gather, 0D index and 0D updates for scatter. (Pa…
6656476 
…ddlePaddle#48452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

@Ligoml Ligoml Ligoml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FeixLiu @Ligoml @zhwesky2010