You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous work of cleaning Sequential under fluid, due to the problem of circular dependency, I copied a copy of Sequential and put it under paddle.nn, and kept the original Sequential under fluid.
In dygraph to static, paddle.fluid.dygraph.dygraph_to_static.convert_call_func.py imports paddle.fluid.dygraph.container.Sequential under fluid on line 27, and performs type judgment on lines 48 and 131, which will lead to an obscure problem. Use paddle.nn.Sequential models will not be able to perform dygraph and static conversions correctly.
So we remove the Sequential under paddle.nn, and will migrate it back after the dygraph to static migration is completed.
你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
之前因为循环依赖的问题，将Sequential复制一份实现放到paddle.nn下，保留原有Sequential实现
在paddle.fluid.dygraph.dygraph_to_static.convert_call_func.py引入了fluid下的Sequential
line 27from paddle.fluid.dygraph.container import Sequential（由于循环依赖无法替换）
line 48 PADDLE_NEED_CONVERT_APIS = [Sequential]
line 131 if type(func) in PADDLE_NEED_CONVERT_APIS: return False
会导致使用paddle.nn.Sequential的部分模型动转静失败（两个Sequential不是同一个类）
The description should be clear why remove paddle.nn Sequential? and what conditions can be met to migrate Sequential in fluid to paddle.nn.Sequential ?
The description should be clear why remove paddle.nn Sequential? and what conditions can be met to migrate Sequential in fluid to paddle.nn.Sequential ?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
In the previous work of cleaning
Sequentialunder fluid, due to the problem of circular dependency, I copied a copy ofSequentialand put it under paddle.nn, and kept the originalSequentialunder fluid.In dygraph to static,
paddle.fluid.dygraph.dygraph_to_static.convert_call_func.pyimportspaddle.fluid.dygraph.container.Sequentialunder fluid on line 27, and performs type judgment on lines 48 and 131, which will lead to an obscure problem. Usepaddle.nn.Sequentialmodels will not be able to perform dygraph and static conversions correctly.So we remove the Sequential under paddle.nn, and will migrate it back after the dygraph to static migration is completed.