Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][isort] introduce isort (part6) #48522

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Nov 29, 2022

PR types

Others

PR changes

Others

Describe

引入 isort 第六部分,主要是前几个 PR 因为避免冲突而 revert 掉的一些文件,以及本 PR 修改配置文件以阻止前几个 PR 修改部分出现增量

剩余的 TODOs(后续 PR):

  • 动转静目录(原 python/paddle/fluid/dygraph/dygraph_to_staticpython/paddle/jit 目录),目前正在迁移,且目前貌似有隐式循环依赖(fluid 内外的动转静模块之间),导致直接 sort 会出现模块找不到的问题,待全部迁移完成后再单独提 PR sort
  • dy2static 单测 test_error.py 需要根据修改行号,单独提 PR
  • 应该可能会有一些增量,如果有的话过一段时间一起修一下就好了

Related links

@paddle-bot
Copy link

paddle-bot bot commented Nov 29, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XiaoguangHu01
XiaoguangHu01 previously approved these changes Nov 30, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit bc01d56 into PaddlePaddle:develop Dec 1, 2022
@SigureMo SigureMo deleted the isort/fix/part6 branch December 1, 2022 01:59
@paddle-bot
Copy link

paddle-bot bot commented Dec 1, 2022

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants