[phi::DenseTensor] Replace Tensor with phi::DenseTensor in .cc files #48525
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Liyulingyue
changed the title
| @@ -302,9 +303,9 @@ row entity to the column entity and the matched indices are not duplicated | |||
| in each row of ColToRowMatchIndices. If the column entity is not matched | |||
| any row entity, set -1 in ColToRowMatchIndices. | |||
|
|
|||
| Please note that the input DistMat can be phi::DenseTensor (with LoD) or Tensor. | |||
| Please note that the input DistMat can be phi::DenseTensor (with LoD) or phi::DenseTensor. | |||
There was a problem hiding this comment.
phi::DenseTensor (with LoD) or phi::DenseTensor 合并为一处DenseTensor即可
There was a problem hiding this comment.
请确认第307-308行的内容，此处的or应该不能轻易删除。 @zyfncg
| class AdamaxOpMaker : public framework::OpProtoAndCheckerMaker { | ||
| public: | ||
| void Make() override { | ||
| AddInput("Param", "(Tensor) Input parameter"); | ||
| AddInput("Grad", "(Tensor) Input gradient"); | ||
| AddInput("LearningRate", "(Tensor) Learning rate"); | ||
| AddInput("Moment", "(Tensor) First moment"); | ||
| AddInput("Param", "(phi::DenseTensor) Input parameter"); | ||
| AddInput("Grad", "(phi::DenseTensor) Input gradient"); | ||
| AddInput("LearningRate", "(phi::DenseTensor) Learning rate"); | ||
| AddInput("Moment", "(phi::DenseTensor) First moment"); | ||
| AddInput("InfNorm", | ||
| "(Tensor) " | ||
| "(phi::DenseTensor) " | ||
| "Input exponentially weighted infinity norm"); | ||
| AddInput("Beta1Pow", "(Tensor) Input beta1 power accumulator"); | ||
| AddInput("Beta1Pow", "(phi::DenseTensor) Input beta1 power accumulator"); | ||
|
|
||
| AddOutput("ParamOut", "(Tensor) Output parameter"); | ||
| AddOutput("MomentOut", "(Tensor) Output first moment"); | ||
| AddOutput("ParamOut", "(phi::DenseTensor) Output parameter"); | ||
| AddOutput("MomentOut", "(phi::DenseTensor) Output first moment"); | ||
| AddOutput("InfNormOut", | ||
| "(Tensor) " | ||
| "(phi::DenseTensor) " |
There was a problem hiding this comment.
由于OpMaker中的部分参数不仅支持DenseTensor类型，也支持SelectedRows类型，因此目前OpMaker中注释的Tensor写法建议保留，暂不替换为DenseTensor
There was a problem hiding this comment.
其他文件(xxx_op.cc)中的OpMaker相关的代码也建议暂时先不做替换，有哪些算子的哪些参数支持SelectedRows目前不太好一一排查，修改之后可能会出现误导的情况
There was a problem hiding this comment.
其他文件(xxx_op.cc)中的
OpMaker相关的代码也建议暂时先不做替换，有哪些算子的哪些参数支持SelectedRows目前不太好一一排查，修改之后可能会出现误导的情况
鉴于此种情况，我建议关闭这个pr，然后通过新的规则进行新的pr。请确认以下，除了(xxx_op.cc)中的OpMaker相关的代码外，还有.h和.cu中也有类似情况吗？
There was a problem hiding this comment.
.cu和.h可以不用考虑
.cu中不会出现OpMaker的代码；.h文件中可能会有，不过看了下这个PR里没有涉及到
There was a problem hiding this comment.
.cu和.h可以不用考虑 .cu中不会出现
OpMaker的代码；.h文件中可能会有，不过看了下这个PR里没有涉及到
对，这个pr主要在尝试去除using Tensor = phi::DenseTensor的使用，计划合入后去除.h和.cu以及剩余通过include方式引入Tensor的.cc文件中的Tensor。现在考虑到需要避开OpMaker，因此计划新开PR进行一次性剔除。
那么.h文件中需要对Opmaker进行规避吗？
|
很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。 |
PR types
Others
PR changes
Others
Describe
Replace Tensor with phi::DenseTensor in .cc files
Related links