Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][CodeStyle] replace self-defined parameterized function with third-party library #48701

Closed
wants to merge 4 commits into from

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Dec 4, 2022

PR types

Others

PR changes

Others

Describe

将单测中自行定义的 parameterized 函数替换为第三方库定义好的 parameterized 函数,以消除重复代码,避免增加维护的成本,见 #47869 (comment)

貌似单测有点问题……唔又要修单测了,之后再说……

@paddle-bot
Copy link

paddle-bot bot commented Dec 4, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Dec 4, 2022
@SigureMo SigureMo changed the title [CodeStyle] replace self-defined parameterized function with third-party library [WIP][CodeStyle] replace self-defined parameterized function with third-party library Dec 4, 2022
@paddle-bot

This comment was marked as off-topic.

@paddle-bot

This comment was marked as off-topic.

@SigureMo SigureMo deleted the ut/parameterized branch July 31, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant