Adding increment op #4940
Adding increment op #4940
Conversation
paddle/operators/increment_op.cc
Outdated
| The equation is: Out = X + step | ||
| )DOC"); | ||
| AddAttr<AttrType>("step", "The scaling factor of the scale operator.") | ||
| .SetDefault(1.0); |
There was a problem hiding this comment.
The comments are not correct. The step is not the scaling factor. Maybe We can implement this math operation in the https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/activation_op.h .
And maybe the name activation_op is not an accurate name, all these activations can be also used as the math operation.
Another option, we can modify the scale operator, let it support:
y = a * x + b
There was a problem hiding this comment.
Thanks for pointing out the mistake in the comment. I forgot to change it. I will fix it immediately.
@qingqing01 I really like your idea of changing the scale op. However, then we might have to rename it because the word scale mean will only imply the multiplicative factor.
There was a problem hiding this comment.
Oh, you are right. One operator is benefit to save memory. But I approve this PR.
Fixes #4912