Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][py36] update requirements.txt and setup.py.in #49516

Merged
merged 2 commits into from
Jan 4, 2023
Merged

[CodeStyle][py36] update requirements.txt and setup.py.in #49516

merged 2 commits into from
Jan 4, 2023

Conversation

gsq7474741
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

更新 ut 的 requirements 和 setup.py.in

related works

@paddle-bot
Copy link

paddle-bot bot commented Jan 3, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 3, 2023
@gsq7474741 gsq7474741 mentioned this pull request Jan 3, 2023
Closed
SigureMo
SigureMo reviewed Jan 3, 2023
View reviewed changes
python/setup.py.in
@@ -816,6 +816,8 @@ with redirect_stdout():
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.7-3.6 可以移除啦～另外 setup.py 也更新一下吧，目前两个应该需要同时维护的，这两天还加了个 CI 检查项检查这个（#49410）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

python/unittest_py/requirements.txt Outdated Show resolved Hide resolved
@SigureMo SigureMo mentioned this pull request Jan 3, 2023
Closed
SigureMo
SigureMo approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM～

@luotao1 luotao1 self-assigned this Jan 4, 2023
@luotao1
Copy link
Contributor

luotao1 commented Jan 4, 2023

zhangbo9674
zhangbo9674 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 77e432e into PaddlePaddle:develop Jan 4, 2023
@gsq7474741
Copy link
Contributor Author

我新提了一个，#48630 就当做目录吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@SigureMo SigureMo SigureMo approved these changes

@zyfncg zyfncg zyfncg approved these changes

Assignees

@luotao1 luotao1

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gsq7474741 @luotao1 @zyfncg @SigureMo @zhangbo9674