[CodeStyle][py36] Update dockerfile and some script #49558
Conversation
# Conflicts: # python/paddle/README.md
# Conflicts: # python/unittest_py/requirements.txt
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
maccheck_py35 会被运行，去掉后ci报错 |
请 @tianshuo78520a 后续帮忙处理下。 @gsq7474741 请解决下 CodeStyle 流水线的格式问题 |
| @@ -64,7 +64,7 @@ function do_cpython_build { | |||
| local prefix="/opt/_internal/cpython-${py_ver}${dir_suffix}" | |||
| mkdir -p ${prefix}/lib | |||
| # -Wformat added for https://bugs.python.org/issue17547 on Python 2.6 | |||
|
|
|||
| # TODO(gsq7474741): 这里要求的python版本是否需要更新？ | |||
There was a problem hiding this comment.
@gsq7474741 因为79行开始有对py37的处理，所以68-75行可以直接删掉
There was a problem hiding this comment.
这些操作 #48490 已经做了，这个 PR 先不动这几个文件吧，我看那个 PR 已经清理地很彻底了～
以下几个文件这个 PR 可以先不动：
tools/dockerfile/build_scripts/build.shtools/dockerfile/build_scripts/build_utils.shtools/dockerfile/ci_dockerfile.shtools/dockerfile/Dockerfile.centos
|
maccheck_py35 改名 为maccheck_py3: |
# Conflicts: # paddle/scripts/paddle_build.sh # tools/dockerfile/build_scripts/build.sh # tools/dockerfile/build_scripts/build_utils.sh
paddle/scripts/paddle_build.sh
Outdated
| run_mac_test ${PYTHON_ABI:-""} ${PROC_RUN:-1} | ||
| ;; | ||
| maccheck_py3) | ||
| cmake_gen_and_build_mac ${PYTHON_ABI:-""} |
There was a problem hiding this comment.
4111行和4115行有两个maccheck_py3（4111行应该是maccheck），重复了。merge最新的develop后，这块不用改了。
| @@ -77,19 +77,7 @@ function cmake_base() { | |||
| SYSTEM=`uname -s` | |||
| if [ "$SYSTEM" == "Darwin" ]; then | |||
| echo "Using python abi: $1" | |||
| if [ "$1" == "cp36-cp36m" ] || [ "$1" == "" ]; then | |||
There was a problem hiding this comment.
这里[ "$1" == "" ]的case是不是漏掉了？py37判断时加上这个case吧
|
已更新 |
PR types
Others
PR changes
Others
Describe
更新一些 dockerfile 和脚本
related works