Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dy2St] 移除 ProgramTranslator #49628

Merged
merged 21 commits into from
Jan 11, 2023
Merged

[Dy2St] 移除 ProgramTranslator #49628

merged 21 commits into from
Jan 11, 2023

Conversation

DrRyanHuang
Copy link
Member

PR types

Others

PR changes

Others

Describe

@paddle-bot
Copy link

paddle-bot bot commented Jan 8, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 8, 2023
Aurelius84
Aurelius84 previously approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 mentioned this pull request Jan 9, 2023
Closed
@luotao1
Copy link
Contributor

luotao1 commented Jan 10, 2023

  • 请解决下冲突
  • 代码示例在本地跑会hang住么？Rerun两次都hang住了
    4cba1af53015423f7d153d2f4630a8e4

@DrRyanHuang
Copy link
Member Author

请解决下冲突
代码示例在本地跑会hang住么？Rerun两次都hang住了

您好，我回滚了 ProgramTranslator 类内的方法，但其没有对外暴露，我本地 win10 跑示例代码没有问题，不知道这次跑
PR-CI-Static-Check 会不会 hang 住，目前在等待 APPROVAL

XiaoguangHu01
XiaoguangHu01 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 2bb28f3 into PaddlePaddle:develop Jan 11, 2023
@DrRyanHuang DrRyanHuang deleted the import_new branch January 20, 2023 15:39
@SigureMo SigureMo mentioned this pull request Jul 1, 2023
Merged
@SigureMo SigureMo mentioned this pull request Oct 21, 2023
Merged
@DrRyanHuang DrRyanHuang mentioned this pull request Dec 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ligoml Ligoml Ligoml approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

Assignees

@luotao1 luotao1

@Aurelius84 Aurelius84

@0x45f 0x45f

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DrRyanHuang @luotao1 @Aurelius84 @Ligoml @XiaoguangHu01 @0x45f