Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI decoupling]migrate device_wrapper.h from fluid to phi #49670

Closed
wants to merge 1 commit into from
Closed

[PHI decoupling]migrate device_wrapper.h from fluid to phi #49670

wants to merge 1 commit into from

Conversation

DrRyanHuang
Copy link
Member

PR types

Others

PR changes

Others

Describe

@paddle-bot
Copy link

paddle-bot bot commented Jan 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@DrRyanHuang
Copy link
Member Author

@YuanRisheng 打扰了,想问下这个 timeout 该怎么改嘞

2023-01-10 10:47:19 The following tests FAILED: 
2023-01-10 10:47:19 	1976 - test_elementwise_add_mkldnn_op (Timeout)
2023-01-10 10:47:19 	2192 - test_mkldnn_conv_concat_relu_mkldnn_fuse_pass (Timeout)
2023-01-10 10:47:19             	1548 - test_dist_se_resnext_nccl (Timeout)
2023-01-10 10:47:19             	1976 - test_elementwise_add_mkldnn_op (Timeout)
2023-01-10 10:47:19             	2192 - test_mkldnn_conv_concat_relu_mkldnn_fuse_pass (Timeout)

@YuanRisheng
Copy link
Contributor

@YuanRisheng 打扰了,想问下这个 timeout 该怎么改嘞

2023-01-10 10:47:19 The following tests FAILED: 
2023-01-10 10:47:19 	1976 - test_elementwise_add_mkldnn_op (Timeout)
2023-01-10 10:47:19 	2192 - test_mkldnn_conv_concat_relu_mkldnn_fuse_pass (Timeout)
2023-01-10 10:47:19             	1548 - test_dist_se_resnext_nccl (Timeout)
2023-01-10 10:47:19             	1976 - test_elementwise_add_mkldnn_op (Timeout)
2023-01-10 10:47:19             	2192 - test_mkldnn_conv_concat_relu_mkldnn_fuse_pass (Timeout)

Rerun一下试试

@DrRyanHuang
Copy link
Member Author

有一个单测报错了,可能是单测的bug ?

#49615

2023-01-10 14:06:53 ======================================================================
2023-01-10 14:06:53 ERROR: test (test_trt_convert_reduce.TrtConvertReduceTest)
2023-01-10 14:06:53 ----------------------------------------------------------------------
2023-01-10 14:06:53 Traceback (most recent call last):
2023-01-10 14:06:53   File "/mnt/paddle/build/python/paddle/fluid/tests/unittests/ir/inference/test_trt_convert_reduce.py", line 180, in test
2023-01-10 14:06:53     self.run_test()
2023-01-10 14:06:53   File "/mnt/paddle/build/python/paddle/fluid/tests/unittests/ir/inference/auto_scan_test.py", line 749, in run_test
2023-01-10 14:06:53     for prog_config in self.sample_program_configs(*args, **kwargs):
2023-01-10 14:06:53   File "/mnt/paddle/build/python/paddle/fluid/tests/unittests/ir/inference/test_trt_convert_reduce.py", line 119, in sample_program_configs
2023-01-10 14:06:53     if not self.is_program_valid(program_config):
2023-01-10 14:06:53   File "/mnt/paddle/build/python/paddle/fluid/tests/unittests/ir/inference/test_trt_convert_reduce.py", line 35, in is_program_valid
2023-01-10 14:06:53     for x in attrs[0]["dim"]:
2023-01-10 14:06:53 KeyError: 'dim'

@YuanRisheng
Copy link
Contributor

有一个单测报错了,可能是单测的bug ?

#49615

2023-01-10 14:06:53 ======================================================================
2023-01-10 14:06:53 ERROR: test (test_trt_convert_reduce.TrtConvertReduceTest)
2023-01-10 14:06:53 ----------------------------------------------------------------------
2023-01-10 14:06:53 Traceback (most recent call last):
2023-01-10 14:06:53   File "/mnt/paddle/build/python/paddle/fluid/tests/unittests/ir/inference/test_trt_convert_reduce.py", line 180, in test
2023-01-10 14:06:53     self.run_test()
2023-01-10 14:06:53   File "/mnt/paddle/build/python/paddle/fluid/tests/unittests/ir/inference/auto_scan_test.py", line 749, in run_test
2023-01-10 14:06:53     for prog_config in self.sample_program_configs(*args, **kwargs):
2023-01-10 14:06:53   File "/mnt/paddle/build/python/paddle/fluid/tests/unittests/ir/inference/test_trt_convert_reduce.py", line 119, in sample_program_configs
2023-01-10 14:06:53     if not self.is_program_valid(program_config):
2023-01-10 14:06:53   File "/mnt/paddle/build/python/paddle/fluid/tests/unittests/ir/inference/test_trt_convert_reduce.py", line 35, in is_program_valid
2023-01-10 14:06:53     for x in attrs[0]["dim"]:
2023-01-10 14:06:53 KeyError: 'dim'

今天有人合入了有问题的代码,等待修复吧

Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device_wrapper.h似乎只是重命名了一下,该文件里的头文件还是fluid头文件,我们原则上不允许为了解耦当前Fluid头文件而引入额外其他Fluid头文件

@DrRyanHuang
Copy link
Member Author

device_wrapper.h似乎只是重命名了一下,该文件里的头文件还是fluid头文件,我们原则上不允许为了解耦当前Fluid头文件而引入额外其他Fluid头文件

好的,我修改一下

@paddle-bot
Copy link

paddle-bot bot commented Feb 3, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants