Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 空指针 (Null pointer) of case 2 paddle.linalg.lu_unpack #49976

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Fix 空指针 (Null pointer) of case 2 paddle.linalg.lu_unpack #49976

merged 4 commits into from
Jan 30, 2023

Conversation

RedContritio
Copy link
Contributor

@RedContritio RedContritio commented Jan 21, 2023 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

Solution

  • 在问题直接发生地，OneFunctor 限制其写入的指针非空
  • 允许 batchsize 为 0
  • 添加了对 pivots 的类型检查

@RedContritio RedContritio mentioned this pull request Jan 21, 2023
Closed
@paddle-bot
Copy link

paddle-bot bot commented Jan 21, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 21, 2023
@RedContritio RedContritio changed the title add arguments validation in lu_unpack Fix 空指针 (Null pointer) of case 2 paddle.linalg.lu_unpack Jan 21, 2023
@luotao1 luotao1 mentioned this pull request Jan 21, 2023
Closed
wanghuancoder
wanghuancoder approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 6f8ec22 into PaddlePaddle:develop Jan 30, 2023
pangengzheng pushed a commit to pangengzheng/Paddle that referenced this pull request Feb 2, 2023
@RedContritio @pangengzheng
Fix 空指针 (Null pointer) of case 2 paddle.linalg.lu_unpack (PaddlePaddl…
b3d98c6 
…e#49976)

* add pivots type check and fix batchsize error

* add unittest for batchsize = 0

* fix nullptr in lu_unpack

fix batchsize error in LU_Unpack
add nullptr check in OneFunctor

* remove exception in device code
@RedContritio RedContritio deleted the lu_unpack branch February 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

@zhiboniu zhiboniu

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedContritio @wanghuancoder @luotao1 @zhiboniu