[PHI Decoupling]Remove Profiler header (Part3) #50721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
heavyrain-lzy
approved these changes
Feb 22, 2023
zyfncg
reviewed
Feb 22, 2023
| @@ -0,0 +1,39 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
| @@ -30,10 +31,8 @@ class RuntimeContext; | |||
| } | |||
| namespace platform { | |||
|
|
|||
| class RecordOpInfoSupplement { | |||
| class RecordOpInfoSupplement : public phi::RecordOpInfoSupplement { | |||
There was a problem hiding this comment.
实际上不同名，因为命名空间不一样，继承是为了能够使用phi::RecordOpInfoSupplement当中的函数
rainyfly
approved these changes
Feb 23, 2023
zyfncg
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
迁移Profiler组件并移除对"paddle/fluid/platform/profiler/supplement_tracing.h"的依赖