[phi decoupling] decouple dependency to device_context in phi (Part 1) #50865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… move_device_context
… move_device_context
huangjiyi
changed the title
… move_device_context
… move_device_context
zyfncg
reviewed
Mar 3, 2023
… move_device_context
YuanRisheng
previously approved these changes
Mar 3, 2023
… move_device_context
…ddle into move_device_context
YuanRisheng
approved these changes
Mar 6, 2023
heavyrain-lzy
approved these changes
Mar 6, 2023
luotao1
approved these changes
Mar 6, 2023
zyfncg
approved these changes
Mar 6, 2023
This was referenced Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Pcard-66980
背景：飞桨算子体系重构 - PHI算子库独立编译
本 PR 解耦大部分 phi 算子库对
paddle/fluid/platform/device_context.h头文件的依赖上图为解耦前 phi 对 fluid device_context 的依赖关系示意图，fluid 下的 device_context 定义了关于不同设备的 DeviceContext 以及实现根据 place 获取 DeviceContext 功能的 DeviceContextPool，其中 IPU、MLU、NPU 没有在 phi 下被用到，同时依赖较多，因此不迁移至 phi 下，而其余 DeviceContext 在 phi 下已有实现。
而 DeviceContextPool 在 phi 下的用法较多，且没有替代方案，因此需要迁移至 phi 下，但是 DeviceContextPool 的实现需要用到所有的 DeviceContext，所以问题在于如何在不迁移所有 DeviceContext 的情况下将 DeviceContextPool 迁移至 phi 下，经讨论，决定将实现向 DeviceContextPool 中插入 EmplaceDeviceContexts 的函数拆分成两个函数：
解耦后的调用关系如下图所示：
在 fluid 下定义的 EmplaceExternalContext 则通过函数指针传递给 EmplaceDeviceContexts，从而不影响 DeviceContextPool 在 fluid 下的使用（因为 EmplaceDeviceContexts 只在进行 DeviceContextPool::Init() 时调用，如果在 fluid 下调用需传递 EmplaceExternalContext 函数指针，而在 phi 下调用则传递一个空指针即可）