Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PaddlePaddle Hackathon 第四期】No1：为 Paddle 新增 finfo API #50987

Merged
merged 4 commits into from
Mar 6, 2023
Merged

【PaddlePaddle Hackathon 第四期】No1：为 Paddle 新增 finfo API #50987

merged 4 commits into from
Mar 6, 2023

Conversation

lisamhy
Copy link
Contributor

@lisamhy lisamhy commented Feb 27, 2023 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

为 Paddle 新增 finfo API

PaddlePaddle/community#388
PaddlePaddle/community#406
PaddlePaddle/docs#5660

@paddle-bot
Copy link

paddle-bot bot commented Feb 27, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Feb 27, 2023
This was referenced Feb 27, 2023
Closed
Merged
@lisamhy lisamhy changed the title 【PaddlePaddle Hackathon 第四期】No.1：为 Paddle 新增 finfo API 【PaddlePaddle Hackathon 第四期】No1：为 Paddle 新增 finfo API Feb 27, 2023
@lisamhy
Copy link
Contributor Author

lisamhy commented Feb 28, 2023

@luotao1 请问怎么才能通过cla？一直没有通过

@lisamhy lisamhy closed this Feb 28, 2023
@paddle-bot
Copy link

paddle-bot bot commented Feb 28, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@lisamhy lisamhy reopened this Feb 28, 2023
@lisamhy
Copy link
Contributor Author

lisamhy commented Feb 28, 2023 •
edited
Loading

@cxxly @luotao1 @cloud2009 @jzhang533 辛苦review，#50987 (comment)

@lisamhy
Copy link
Contributor Author

lisamhy commented Mar 1, 2023 •
edited
Loading

@cxxly @luotao1 @cloud2009 @jzhang533 已经修改，辛苦review，#50987 (comment)

1 similar comment
@lisamhy
Copy link
Contributor Author

lisamhy commented Mar 2, 2023

@cxxly @luotao1 @cloud2009 @jzhang533 已经修改，辛苦review，#50987 (comment)

cxxly
cxxly previously approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@cxxly cxxly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404
Copy link
Contributor

code is fine, but rfc is inconsistent with code, especially in chapter 5, API implementation(API实现方案) is described repeatedly and both are different from the code.

@lisamhy
Copy link
Contributor Author

lisamhy commented Mar 2, 2023

PaddlePaddle/community#406

rfc 已更新，麻烦review @jeff41404 @cxxly @luotao1 @cloud2009

如果没有别的问题，麻烦帮忙 merge，辛苦。

jeff41404
jeff41404 previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 reviewed Mar 3, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

规范参数描述的格式

python/paddle/framework/dtype.py Outdated Show resolved Hide resolved
@lisamhy
Copy link
Contributor Author

lisamhy commented Mar 3, 2023

@sunzhongkai588 文档已修复辛苦review

sunzhongkai588
sunzhongkai588 reviewed Mar 3, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有一个小typo修复即可～

python/paddle/framework/dtype.py Outdated

- min(double): The smallest representable number (typically `-max`).
- max(double): The largest representable number.
- eps(double): The smallest representable number such that `1.0 + eps != 1.0`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请直接使用不等号 ≠

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunzhongkai588 已经修改，辛苦review合入

sunzhongkai588
sunzhongkai588 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lisamhy
Copy link
Contributor Author

lisamhy commented Mar 6, 2023

@jeff41404 @cxxly @sunzhongkai588 @luotao1 已经修改，辛苦review合入

@luotao1 luotao1 merged commit f84f43c into PaddlePaddle:develop Mar 6, 2023
@luotao1
Copy link
Contributor

luotao1 commented Mar 6, 2023

请对应修改下中文文档 PR

@luotao1
Copy link
Contributor

luotao1 commented Mar 6, 2023

hi, @lisamhy

  • 非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

@luotao1 luotao1 mentioned this pull request Mar 6, 2023
Closed
@Ligoml Ligoml mentioned this pull request Mar 7, 2023
Closed
@luotao1 luotao1 mentioned this pull request Mar 8, 2023
Closed
@luotao1 luotao1 mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

@jeff41404 jeff41404 jeff41404 left review comments

@cxxly cxxly cxxly left review comments

Assignees

@luotao1 luotao1

@cxxly cxxly

@Ligoml Ligoml

@cloud2009 cloud2009

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lisamhy @jeff41404 @luotao1 @cxxly @sunzhongkai588 @Ligoml @cloud2009